[image-picker][android] Fix non-serializable type #23768
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
up 🙌🏼 |
lukmccall
approved these changes
Aug 18, 2023
EvanBacon
pushed a commit
that referenced
this pull request
Aug 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Partially addresses #23447. The
Uritype is not serializable and will cause a crash when recreating the activity if it has been destroyed.How
Switch from using
UritoStringand convert back and forth where necessaryTest Plan
When setting the developer option
Don't keep activitiesevery activity is destroyed after they are left. While using aUrithis would crash with aNotSerializableException, using aStringresolves this but it still crashes. When the activity is recreated, the expo module is not recreated or at least not soon enough to prevent a crash.