add as property instead of method

electron · Aug 30, 2023 · f86cf55 · f86cf55
1 parent 8b68f32
commit f86cf55
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 11 deletions.
diff --git a/docs/api/system-preferences.md b/docs/api/system-preferences.md
@@ -415,15 +415,11 @@ Returns `Object`:
 
 Returns an object with system animation settings.
 
-### `systemPreferences.getAccessibilityDisplayShouldReduceTransparency()` _macOS_
-
-Returns `boolean` - Returns whether the app avoids using semitransparent backgrounds. This maps to [NSWorkspace.accessibilityDisplayShouldReduceTransparency](https://developer.apple.com/documentation/appkit/nsworkspace/1533006-accessibilitydisplayshouldreduce)
-
 ## Properties
 
 ### `systemPreferences.accessibilityDisplayShouldReduceTransparency()` _macOS_
 
-A `boolean` property. It determines whether the app avoids using semitransparent backgrounds. This maps to [NSWorkspace.accessibilityDisplayShouldReduceTransparency](https://developer.apple.com/documentation/appkit/nsworkspace/1533006-accessibilitydisplayshouldreduce)
+A `boolean` property which determines whether the app avoids using semitransparent backgrounds. This maps to [NSWorkspace.accessibilityDisplayShouldReduceTransparency](https://developer.apple.com/documentation/appkit/nsworkspace/1533006-accessibilitydisplayshouldreduce)
 
 ### `systemPreferences.appLevelAppearance` _macOS_ _Deprecated_
 

diff --git a/shell/browser/api/electron_api_system_preferences.cc b/shell/browser/api/electron_api_system_preferences.cc
@@ -99,12 +99,9 @@ gin::ObjectTemplateBuilder SystemPreferences::GetObjectTemplateBuilder(
       .SetMethod("isTrustedAccessibilityClient",
                  &SystemPreferences::IsTrustedAccessibilityClient)
       .SetMethod("askForMediaAccess", &SystemPreferences::AskForMediaAccess)
-      .SetMethod(
-          "getAccessibilityDisplayShouldReduceTransparency",
-          &SystemPreferences::getAccessibilityDisplayShouldReduceTransparency)
       .SetProperty(
           "accessibilityDisplayShouldReduceTransparency",
-          &SystemPreferences::getAccessibilityDisplayShouldReduceTransparency)
+          &SystemPreferences::GetAccessibilityDisplayShouldReduceTransparency)
 #endif
       .SetMethod("getAnimationSettings",
                  &SystemPreferences::GetAnimationSettings);

diff --git a/shell/browser/api/electron_api_system_preferences.h b/shell/browser/api/electron_api_system_preferences.h
@@ -96,7 +96,7 @@ class SystemPreferences
                       gin::Arguments* args);
   void RemoveUserDefault(const std::string& name);
   bool IsSwipeTrackingFromScrollEventsEnabled();
-  bool AccessibilityDisplayShouldReduceTransparency();
+  bool GetAccessibilityDisplayShouldReduceTransparency();
 
   std::string GetSystemColor(gin_helper::ErrorThrower thrower,
                              const std::string& color);

diff --git a/shell/browser/api/electron_api_system_preferences_mac.mm b/shell/browser/api/electron_api_system_preferences_mac.mm
@@ -620,7 +620,7 @@ AVMediaType ParseMediaType(const std::string& media_type) {
   }
 }
 
-bool SystemPreferences::AccessibilityDisplayShouldReduceTransparency() {
+bool SystemPreferences::GetAccessibilityDisplayShouldReduceTransparency() {
   return [[NSWorkspace sharedWorkspace]
       accessibilityDisplayShouldReduceTransparency];
 }