-
Notifications
You must be signed in to change notification settings - Fork 15.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Discussion] Requiring Native Modules in the Renderer Process to be NAPI or Context Aware #18397
Comments
This is cool. I just encountered such situation that needs multiple native module instances, while it is little sad that it only supports node with V8, not N-API. |
Are native modules the only reason for the "new process for every navigation"? The following explanation from @zcbenz seems to suggest that node can't fully tear down its one js environment per process, so a new one can take its place. |
@bughit That situation has changed in recent times, as mentioned in the original issue text with the introduction of worker threads node now supports multiple instances of node per-process along with proper teardown support (this is what making your addon context aware supports). We already teardown node environments when the |
Would you consider adding an experimental option that would deactivate the "process for every navigation" mode even before you completely drop you process model patches? Assuming that's less work than the full job. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Can the decision to remove affinity be reviewed ? I currently don't see a way to open multiple BrowserWindows quickly enough without affinity. This would impact many developers as discussed here - #16319 |
Is there a way to suppress the deprecation warning? I am upgrading to electron 7.x and plan to update my native modules soon, but right now this message floods the log when I run my test suite. (I tried explicitly setting |
All native modules used Electron be context-ware before when upgrading to Electron 14. electron/electron#18397. `git-utils` is still one of the module that isn't context-aware. This commit uses NAN_MODULE_WORKER_ENABLED instead of `NODE_MODULE` to make the module context-aware.
All native modules used Electron be context-ware before when upgrading to Electron 14. electron/electron#18397. `git-utils` is still one of the module that isn't context-aware. This commit uses NAN_MODULE_WORKER_ENABLED instead of `NODE_MODULE` to make the module context-aware.
All native modules used Electron be context-ware before when upgrading to Electron 14. electron/electron#18397. `git-utils` is still one of the module that isn't context-aware. This commit uses NAN_MODULE_WORKER_ENABLED instead of `NODE_MODULE` to make the module context-aware.
All native modules used Electron be context-ware before when upgrading to Electron 14. electron/electron#18397. `git-utils` is still one of the module that isn't context-aware. This commit uses NAN_MODULE_WORKER_ENABLED instead of `NODE_MODULE` to make the module context-aware.
All native modules used Electron be context-ware before when upgrading to Electron 14. electron/electron#18397. `git-utils` is still one of the module that isn't context-aware. This commit uses NAN_MODULE_WORKER_ENABLED instead of `NODE_MODULE` to make the module context-aware.
All native modules used Electron be context-ware before when upgrading to Electron 14. electron/electron#18397. `git-utils` is still one of the module that isn't context-aware. This commit uses NAN_MODULE_WORKER_ENABLED instead of `NODE_MODULE` to make the module context-aware.
All native modules used Electron be context-ware before when upgrading to Electron 14. electron/electron#18397. `git-utils` is still one of the module that isn't context-aware. This commit uses NAN_MODULE_WORKER_ENABLED instead of `NODE_MODULE` to make the module context-aware.
All native modules used Electron be context-ware before when upgrading to Electron 14. electron/electron#18397. `git-utils` is still one of the module that isn't context-aware. This commit uses NAN_MODULE_WORKER_ENABLED instead of `NODE_MODULE` to make the module context-aware.
All native modules used Electron be context-ware before when upgrading to Electron 14. electron/electron#18397. `git-utils` is still one of the module that isn't context-aware. This commit uses NAN_MODULE_WORKER_ENABLED instead of `NODE_MODULE` to make the module context-aware.
All native modules used Electron be context-ware before when upgrading to Electron 14. electron/electron#18397. `git-utils` is still one of the module that isn't context-aware. This commit uses NAN_MODULE_WORKER_ENABLED instead of `NODE_MODULE` to make the module context-aware.
All native modules used Electron be context-ware before when upgrading to Electron 14. electron/electron#18397. `git-utils` is still one of the module that isn't context-aware. This commit uses NAN_MODULE_WORKER_ENABLED instead of `NODE_MODULE` to make the module context-aware.
All native modules used Electron be context-ware before when upgrading to Electron 14. electron/electron#18397. `git-utils` is still one of the module that isn't context-aware. This commit uses NAN_MODULE_WORKER_ENABLED instead of `NODE_MODULE` to make the module context-aware.
Since Electron 14, all native addons must be context-aware. Therefore, in order to make node-tree-sitter run with Electron >= 14, it has to be context-aware. Ref: electron/electron#18397 In this commit, NAN_MODULE_WORKER_ENABLED is used to make the native addon context-aware. It will allow context as the third param but will ignore it. This change doesn't mean that the addon will be safe to be initialised multiple times so can be run on worker threads though. Perhaps, someone with better understanding of the library need to implement AddEnvironmentCleanupHook to clean up resources. Ref: https://nodejs.org/api/addons.html#context-aware-addons
Native modules in Electron
Loading native modules in Electron has always been tricky. It's a pain to rebuild, to link to the right
node.lib/dll
, and to ensure yourNODE_MODULE_VERSION
is correct. And there's another problem behind the scenes that most users have never had to deal with: Node doesn't let you load multiple instances of a native module in the same process, even in different v8 contexts. Imagine this scenario:We address this in Electron by patching Chromium to create a new process for every navigation. This mostly works but still has a few edge cases (e.g. #4025, #12045, #17576) and a few side effects:
window.open
andwindow.opener
as we force child windows into separate processes sometimes. 😢We've always thought "wouldn't it be cool if we could change this". Now, with Node 12's Worker Threads, we see a way to do that.
Worker Threads
Node ran into the same issue when they added worker threads: native modules could not be loaded in multiple workers. Node solved this by introducing the concept of "Context Aware" native modules. This is how native modules tell Node that they are safe to be loaded in multiple
v8::Context
s. Nan has a handy helper (NAN_MODULE_WORKER_ENABLED
) for doing this.Context Aware modules and NAPI modules can be instantated multiple times in Node even without our patched process model. As they become more common, our patches will bring less benefit and be more redundant.
What does this mean for Electron?
Right now, nothing. However, at some point in the future -- probably in a few major versions -- we intend to remove our process model patches. At that point, any native Node modules loaded in the renderer process must be either NAPI or Context Aware.
This won't happen tomorrow. It probably won't happen this year. But it will happen, so if you're using or maintaining a native module, you should start looking at the work to mark it as Context Aware. For lots of modules it's as easy as replacing
NODE_MODULE
withNAN_MODULE_WORKER_ENABLED
. For modules that require cleanup, it can be more involved.You may be wondering why we're changing something that (mostly) works? The main reasons are:
What does this look like for Native Module X?
The amount of work to become "Context Aware" will be different for every module. For native modules that act as proxies for native getters and setters -- i.e. they just expose JS apis to acccess native APIs -- it's normally as easy as adding a
NAN_MODULE_WORKER_ENABLED
declaration. You can find an example of that in this pull request.Some modules will need to do cleanup when the context is destroyed to ensure the module doesn't leaking memory or to cause crashes. You can add hooks to clean up after yourself with
node::AddEnvironmentCleanupHook
A minimal example of this can be found in this pull request.Timeline
app.allowRendererProcessReuse
option in Electron 6app.allowRendererProcessReuse
to switchapp.allowRendererProcessReuse
totrue
in Electron 9app.allowRendererProcessReuse
in Electron 10app.allowRendererProcessReuse
in Electron 14The text was updated successfully, but these errors were encountered: