Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: promisify session cache methods #17185

Merged
merged 1 commit into from
Mar 8, 2019
Merged

feat: promisify session cache methods #17185

merged 1 commit into from
Mar 8, 2019

Conversation

codebytere
Copy link
Member

@codebytere codebytere commented Mar 1, 2019 •
edited
Loading

Description of Change

Promisify session.getCacheSize() and session.clearCache().

cc @deepak1556 @zcbenz

Checklist

Release Notes

Notes: Converted session.getCacheSize() and session.clearCache() to return promises instead of taking callbacks.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Mar 1, 2019
@codebytere codebytere marked this pull request as ready for review March 1, 2019 20:08
@codebytere codebytere added the semver/minor backwards-compatible functionality label Mar 1, 2019
deepak1556
deepak1556 requested changes Mar 2, 2019
View reviewed changes
atom/browser/api/atom_api_session.cc Show resolved Hide resolved
atom/browser/api/atom_api_session.cc Outdated Show resolved Hide resolved
atom/browser/api/atom_api_session.cc Outdated Show resolved Hide resolved
atom/browser/api/atom_api_session.cc Outdated Show resolved Hide resolved
atom/browser/api/atom_api_session.cc Outdated Show resolved Hide resolved
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Mar 2, 2019
miniak
miniak reviewed Mar 3, 2019
View reviewed changes
docs/api/session.md Outdated Show resolved Hide resolved
@deepak1556
Copy link
Member

Would like to see this cleaned up after the suggested code style changes in #17222

@codebytere codebytere changed the title feat: promisify some session methods feat: promisify session cachemethods Mar 7, 2019
@codebytere codebytere changed the title feat: promisify session cachemethods feat: promisify session cache methods Mar 7, 2019
miniak
miniak requested changes Mar 7, 2019
View reviewed changes
docs/api/session.md Outdated Show resolved Hide resolved
docs/api/session.md Outdated Show resolved Hide resolved
docs/api/session.md Show resolved Hide resolved
deepak1556
deepak1556 approved these changes Mar 8, 2019
View reviewed changes
Copy link
Member

@deepak1556 deepak1556 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with some style changes.

atom/browser/api/atom_api_session.cc Outdated Show resolved Hide resolved
atom/browser/api/atom_api_session.cc Outdated Show resolved Hide resolved
atom/browser/api/atom_api_session.cc Outdated Show resolved Hide resolved
@codebytere codebytere merged commit fc10620 into master Mar 8, 2019
@release-clerk
Copy link

release-clerk bot commented Mar 8, 2019

Release Notes Persisted

Converted session.getCacheSize() and session.clearCache() to return promises instead of taking callbacks.

@codebytere codebytere deleted the promisify-session branch March 8, 2019 22:42
kiku-jw pushed a commit to kiku-jw/electron that referenced this pull request May 16, 2019
@codebytere @kiku-jw
feat: promisify session cache methods (electron#17185)
e6ec9b4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miniak miniak miniak approved these changes

@deepak1556 deepak1556 deepak1556 approved these changes

Assignees
No one assigned
Labels
semver/minor backwards-compatible functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@codebytere @deepak1556 @miniak