Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump chromium to 122.0.6194.0 (main) #40750

Merged
merged 54 commits into from
Jan 3, 2024
Merged

Conversation

electron-roller[bot]
Copy link
Contributor

@electron-roller electron-roller bot commented Dec 12, 2023

Updating Chromium to 122.0.6194.0.

See all changes in 121.0.6159.0..122.0.6194.0

Notes: Updated Chromium to 122.0.6194.0.

@electron-roller electron-roller bot requested a review from a team as a code owner December 12, 2023 13:00
@electron-roller electron-roller bot added no-backport semver/patch backwards-compatible bug fixes labels Dec 12, 2023
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Dec 12, 2023
@electron-roller electron-roller bot changed the title chore: bump chromium to 122.0.6180.0 (main) chore: bump chromium to 122.0.6181.0 (main) Dec 12, 2023
@electron-roller electron-roller bot requested a review from a team as a code owner December 13, 2023 00:46
@electron-roller electron-roller bot changed the title chore: bump chromium to 122.0.6181.0 (main) chore: bump chromium to 122.0.6182.0 (main) Dec 13, 2023
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Dec 13, 2023
@electron-roller electron-roller bot changed the title chore: bump chromium to 122.0.6182.0 (main) chore: bump chromium to 122.0.6184.0 (main) Dec 14, 2023
@electron-roller electron-roller bot changed the title chore: bump chromium to 122.0.6184.0 (main) chore: bump chromium to 122.0.6186.0 (main) Dec 15, 2023
@electron-roller electron-roller bot changed the title chore: bump chromium to 122.0.6186.0 (main) chore: bump chromium to 122.0.6188.0 (main) Dec 16, 2023
@electron-roller electron-roller bot changed the title chore: bump chromium to 122.0.6188.0 (main) chore: bump chromium to 122.0.6190.0 (main) Dec 17, 2023
@electron-roller electron-roller bot changed the title chore: bump chromium to 122.0.6190.0 (main) chore: bump chromium to 122.0.6192.0 (main) Dec 18, 2023
@electron-roller electron-roller bot changed the title chore: bump chromium to 122.0.6192.0 (main) chore: bump chromium to 122.0.6194.0 (main) Dec 19, 2023
electron-roller bot and others added 13 commits December 21, 2023 14:01
…ting.patch

Xref: https://chromium-review.googlesource.com/c/v8/v8/+/5076902
Xref: https://chromium-review.googlesource.com/c/v8/v8/+/5096253

The `bailout_value` variable, which allowed us to fail gracefully in
these macros, has been removed upstream. This raises the temperature
on #40741 ...

Since we don't have a bailout value, return a default-constructed
instance of whatever the return type is of the function that invokes
the macro.
Xref: https://chromium-review.googlesource.com/c/chromium/src/+/5068017

It appears it is not used by anything within Chromium or outside.
@@ -1451,6 +1451,7 @@ describe('session module', () => {
w.webContents.executeJavaScript(`
var iframe = document.createElement('iframe');
iframe.src = '${loadUrl}';
iframe.allow = 'clipboard-read';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://www.w3.org/TR/permissions-policy-1/ is now enabled for cross origin frames, should be documented under breaking changes.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@codebytere can you add the breaking change doc update to this PR?

@deepak1556
Copy link
Member

The rest of the failing tests related to pending exceptions are a side effect of the following change https://chromium-review.googlesource.com/c/v8/v8/+/5050065, haven't gone through the change yet.

@jkleinsc jkleinsc added target/29-x-y PR should also be added to the "29-x-y" branch. and removed no-backport labels Jan 2, 2024
Copy link
Member

@jkleinsc jkleinsc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending breaking change doc update.

@@ -1451,6 +1451,7 @@ describe('session module', () => {
w.webContents.executeJavaScript(`
var iframe = document.createElement('iframe');
iframe.src = '${loadUrl}';
iframe.allow = 'clipboard-read';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@codebytere can you add the breaking change doc update to this PR?

@electron-roller electron-roller bot requested a review from a team as a code owner January 2, 2024 20:53
@codebytere codebytere merged commit 8c89137 into main Jan 3, 2024
15 checks passed
@codebytere codebytere deleted the roller/chromium/main branch January 3, 2024 08:52
Copy link

release-clerk bot commented Jan 3, 2024

Release Notes Persisted

Updated Chromium to 122.0.6194.0.

@trop
Copy link
Contributor

trop bot commented Jan 3, 2024

I have automatically backported this PR to "29-x-y", please check out #40872

@trop trop bot added in-flight/29-x-y merged/29-x-y PR was merged to the "29-x-y" branch. and removed target/29-x-y PR should also be added to the "29-x-y" branch. in-flight/29-x-y labels Jan 3, 2024
@piotrpdev piotrpdev mentioned this pull request Jul 29, 2024
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged/29-x-y PR was merged to the "29-x-y" branch. roller/pause semver/patch backwards-compatible bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants