Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Options parameter for Session.clearData API #41355

Merged
merged 9 commits into from
Apr 1, 2024
Merged

feat: Options parameter for Session.clearData API #41355

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
4505291
feat: Options parameter for `Session.clearData` API
clavin Feb 13, 2024
3ad52b7
Consolidate & curate data type categories
clavin Feb 21, 2024
f200dea
Update docs for better typing
clavin Mar 4, 2024
69f9dc5
off-by-one typo
clavin Mar 5, 2024
e911f3c
refactor to use `std::shared_ptr` instead of `base::RefCounted`
clavin Mar 14, 2024
39b8e36
fix compile errors
clavin Mar 18, 2024
903a86a
std::enable_shared_from_this didn't work 🤷
clavin Mar 18, 2024
46bfca6
Merge branch 'main' into clavin/session-clear-data-api-enhanced-plus-…
clavin Mar 19, 2024
401dbdf
Refine docs with defaults
clavin Mar 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Consolidate & curate data type categories
  • Loading branch information
@clavin
clavin committed Feb 26, 2024
commit 3ad52b76128832e6e0a8aff11c28c706af631278
2 changes: 0 additions & 2 deletions docs/api/session.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1441,13 +1441,11 @@ Clears various different types of data.

* **Background Fetch**: `backgroundFetch`
* **Cache**: `cache`
* **Cache Storage**: `cacheStorage`
* **Cookies**: `cookies`
* **Downloads**: `downloads`
* **File Systems**: `fileSystems`
* **IndexedDB**: `indexedDB`
* **Local Storage**: `localStorage`
* **Media Licenses**: `mediaLicenses`
* **Service Workers**: `serviceWorkers`
* **WebSQL**: `webSQL`

Expand Down
5 changes: 2 additions & 3 deletions shell/browser/api/electron_api_session.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,14 +165,13 @@ constexpr BrowsingDataRemover::OriginType kClearOriginTypeAll =
constexpr auto kDataTypeLookup =
base::MakeFixedFlatMap<std::string_view, BrowsingDataRemover::DataType>({
{"backgroundFetch", BrowsingDataRemover::DATA_TYPE_BACKGROUND_FETCH},
{"cache", BrowsingDataRemover::DATA_TYPE_CACHE},
{"cacheStorage", BrowsingDataRemover::DATA_TYPE_CACHE_STORAGE},
{"cache", BrowsingDataRemover::DATA_TYPE_CACHE |
BrowsingDataRemover::DATA_TYPE_CACHE_STORAGE},
{"cookies", BrowsingDataRemover::DATA_TYPE_COOKIES},
{"downloads", BrowsingDataRemover::DATA_TYPE_DOWNLOADS},
{"fileSystems", BrowsingDataRemover::DATA_TYPE_FILE_SYSTEMS},
{"indexedDB", BrowsingDataRemover::DATA_TYPE_INDEXED_DB},
{"localStorage", BrowsingDataRemover::DATA_TYPE_LOCAL_STORAGE},
{"mediaLicenses", BrowsingDataRemover::DATA_TYPE_MEDIA_LICENSES},
{"serviceWorkers", BrowsingDataRemover::DATA_TYPE_SERVICE_WORKERS},
{"webSQL", BrowsingDataRemover::DATA_TYPE_WEB_SQL},
});
Expand Down