Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support app#login event for utility process net requests #43317

Merged
merged 2 commits into from
Aug 16, 2024
Merged

feat: support app#login event for utility process net requests #43317

merged 2 commits into from
Aug 16, 2024

Conversation

deepak1556
Copy link
Member

@deepak1556 deepak1556 commented Aug 14, 2024 •
edited by jkleinsc
Loading

Description of Change

Backport of #42631

Release Notes

Notes: Add support for responding to auth requests initiated from utility process via app#login event

@deepak1556
feat: support app#login event for utility process net requests
97c4427 
* feat: support app#login event for utility process net requests

* chore: address review feedback

* GlobalRequestID: Avoid unwanted inlining and narrowing int conversions

Refs https://chromium-review.googlesource.com/c/chromium/src/+/5702737
@deepak1556 deepak1556 requested a review from a team as a code owner August 14, 2024 04:51
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Aug 14, 2024
@deepak1556 deepak1556 added semver/minor backwards-compatible functionality backport-check-skip Skip trop's backport validity checking 32-x-y labels Aug 14, 2024
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Aug 14, 2024
@deepak1556 deepak1556 added backport This is a backport PR backport-check-skip Skip trop's backport validity checking and removed backport-check-skip Skip trop's backport validity checking backport This is a backport PR labels Aug 14, 2024
@jkleinsc jkleinsc removed the backport-check-skip Skip trop's backport validity checking label Aug 14, 2024
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Aug 14, 2024
@trop trop bot mentioned this pull request Aug 14, 2024
Merged
@trop trop bot added the backport This is a backport PR label Aug 14, 2024
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Aug 14, 2024
codebytere
codebytere approved these changes Aug 16, 2024
View reviewed changes
Copy link
Member

@codebytere codebytere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved by @electron/wg-releases on 15/08/2024

@codebytere codebytere merged commit 8c1be5a into 32-x-y Aug 16, 2024
55 checks passed
@codebytere codebytere deleted the robo/backport_app_login_utility_process_32_x_y branch August 16, 2024 09:24
@release-clerk Release Clerk
Copy link

release-clerk bot commented Aug 16, 2024

Release Notes Persisted

Add support for responding to auth requests initiated from utility process via app#login event

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codebytere codebytere codebytere approved these changes

Assignees
No one assigned
Labels
32-x-y backport/requested 🗳 backport This is a backport PR semver/minor backwards-compatible functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@deepak1556 @codebytere @jkleinsc