Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(plugin-webpack): support for dev server custom headers #3653

Merged
merged 5 commits into from
Sep 17, 2024
Merged

feat(plugin-webpack): support for dev server custom headers #3653

merged 5 commits into from
Sep 17, 2024

Conversation

rahul-sachdeva22
Copy link
Contributor

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project follows, as appropriate.
  • The changes are appropriately documented (if applicable).
  • The changes have sufficient test coverage (if applicable).
  • The testsuite passes successfully on my local machine (if applicable).

Summarize your changes:

@rahul-sachdeva22 rahul-sachdeva22 requested a review from a team as a code owner July 11, 2024 12:24
@rahul-sachdeva22 rahul-sachdeva22 changed the title support for dev server custom headers fix - support for dev server custom headers Jul 11, 2024
@rahul-sachdeva22 rahul-sachdeva22 changed the title fix - support for dev server custom headers fix: support for dev server custom headers Jul 11, 2024
BlackHole1
BlackHole1 requested changes Jul 11, 2024
View reviewed changes
packages/plugin/webpack/src/WebpackPlugin.ts Outdated Show resolved Hide resolved
packages/plugin/webpack/src/WebpackPlugin.ts Outdated Show resolved Hide resolved
@BlackHole1 BlackHole1 changed the title fix: support for dev server custom headers feat: support for dev server custom headers Jul 11, 2024
@rahul-sachdeva22
Copy link
Contributor Author

retest

@dsanders11 dsanders11 changed the title feat: support for dev server custom headers feat(plugin-webpack): support for dev server custom headers Jul 25, 2024
@erickzhao erickzhao merged commit 3c2a19b into electron:main Sep 17, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BlackHole1 BlackHole1 BlackHole1 approved these changes

@erickzhao erickzhao erickzhao approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rahul-sachdeva22 @BlackHole1 @erickzhao