Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: limit items on response from ERS #3699

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

PashaFG
Copy link

@PashaFG PashaFG commented Sep 15, 2024

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project follows, as appropriate.
  • The changes are appropriately documented (if applicable).
  • The changes have sufficient test coverage (if applicable).
  • The testsuite passes successfully on my local machine (if applicable).

Summarize your changes:

Issue: #3698

But to the number of elements available for return in the authFetch('versions/sorted') endpoint, if we add an update to an older version. Since in the first N (default: 50), sorted by version name, we do not get the newly created one.

This number is regulated on the electron-release-server side. https://github.com/ArekSredzki/electron-release-server/blob/master/config/views.js#L46

To solve the problem I added a loop refetch versions list, if in response we receive a number of elements less than indicated in request.key total.

I also update interface ERSVersionSorted, because page in response has type string | number, page in ERS takes from query params, but default value is number "0"

@PashaFG PashaFG requested a review from a team as a code owner September 15, 2024 10:16
@PashaFG PashaFG changed the title fix(electron-release-publisher) limit on the number of versions per request on endpoint versions/sorted fix: fix limit items on response from ERS Sep 15, 2024
@PashaFG PashaFG changed the title fix: fix limit items on response from ERS fix: limit items on response from ERS Sep 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants