Add the ability to enforce adding table columns in user defined order #4389
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Some context for why this impacted us. We have our own migration scripts, and we ensure our migration scripts correspond to the schema ent generates by loading both into postgresql and doing a pg_dump and ensuring they are the same. As ALTER TABLE puts columns at end, while ent was sticking them before edges, diff was failing. For now we have worked around it, by writing a small normalize program that sorts the columns that are in the CREATE TABLE block in alphabetical order. A bit ugly, but solves the immediate problem. I still think giving users the ability to control the order of their columns is valuable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had a problem with migrations that when we add fields to ent tables, that ent wants to generate the schema in a different order than what one would get by altering the table. This enables the user to request that ent generate the table columns in the order specified in fields array.