Add max_sessions_per_event_loop to quic protocol options. #41371
+41
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ting Pan <panting@google.com>
|
CC @envoyproxy/api-shepherds: Your approval is needed for changes made to |
Signed-off-by: Ting Pan <panting@google.com>
|
/assign @RyanTheOptimist
|
Signed-off-by: Ting Pan <panting@google.com>
| initialize(); | ||
| const uint32_t max_sessions_per_event_loop_for_test = | ||
| ActiveQuicListener::kNumSessionsToCreatePerLoop; | ||
| EXPECT_EQ(max_sessions_per_event_loop_for_test, |
There was a problem hiding this comment.
nit: Just inline ActiveQuicListener::kNumSessionsToCreatePerLoop directly into the EXPECT_EQ.
| // During hot restart, an optional handler for packets that weren't for existing connections. | ||
| OptRef<Network::NonDispatchedUdpPacketHandler> non_dispatched_udp_packet_handler_; | ||
| Network::IoHandle::UdpSaveCmsgConfig udp_save_cmsg_config_; | ||
| uint32_t max_sessions_per_event_loop_; |
There was a problem hiding this comment.
nit: brief comment (particularly if there are any special semantics attached to particular values)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Message: Add a new quic configuration field, 'max_sessions_per_event_loop', to QuicProtocolOptions in Envoy listener.
Additional Description: This change allows tuning the maximum number of new QUIC sessions created within a single event loop. The default value is 16, preserving the previous hardcoded limit.
Risk Level: low
Testing: unit tests
Docs Changes:
Release Notes: Add max_sessions_per_event_loop to quic protocol options.
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]