transport_sockets: add dynamic TLV support to PROXY protocol upstream socket via format strings #41390
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b566cac to
ebe3f54
Compare
… socket via format strings Signed-off-by: Rohit Agrawal <rohit.agrawal@databricks.com>
ebe3f54 to
d6bfb52
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for dynamically populated TLV values in the PROXY protocol upstream transport socket using
SubstitutionFormatString.For example, users would be able to use
%DYNAMIC_METADATA(...)%,%FILTER_STATE(...)%,%DOWNSTREAM_REMOTE_ADDRESS%, etc. to write the TLVs after this change.We recently introduced similar change for TCP Proxy.
Commit Message: transport_sockets: add dynamic TLV support to PROXY protocol upstream socket via format strings
Additional Description: Adds support for dynamically populated TLV values in the PROXY protocol upstream transport socket using
SubstitutionFormatString.Risk Level: Low
Testing: Added Unit Tests
Docs Changes: Added
Release Notes: Added