tcp_proxy: add support for overriding generated request ID for tunneling #41391
+165
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CC @envoyproxy/api-shepherds: Your approval is needed for changes made to |
2d47f35 to
9621686
Compare
Signed-off-by: Rohit Agrawal <rohit.agrawal@databricks.com>
9621686 to
0b0a8a3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds two optional configs to override the header name which carries the generated request ID for the tunneling requests from TCP Proxy as well as the key of the dynamic metadata we emit.
This is very useful when we don't want the
x-request-idto be used here as a default which could have other implications if the upstream service is an Envoy which is configured to use the incoming Request ID.Commit Message: tcp_proxy: add support for overriding generated request ID for tunneling
Additional Description: Adds two optional configs to override the header name which carries the generated request ID for the tunneling requests from TCP Proxy as well as the key of the dynamic metadata we emit.
Risk Level: Low
Testing: Added Unit + Integration Tests
Docs Changes: Added
Release Notes: Added