Use the global screen for geometry strings which don't specify a monitor #814
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When setting FvwmIconMan's ManagerGeometry string, the caller was using FScreenParseGeometryWithScreen, which throws away the geometry string when no screen is specified. Callers of this function are a holdover from introducing Xinerama, and hasn't fared any better when RandR replaces Xinerama. Calling FScreenParseGeometry instead makes the parsing of the geometry string, and this is what other modules -- such as FvwmButtons is doing. In doing so, the logic for how screens were being handled was broken. Rather than assume the PRIMARY screen before checking if we have a geometry string, remove that and let the geometry string override anything else. If one isn't supplied, use the existing logic. Fixes #813
When a user uses a geometry string without fvwm's extension, ensure that
geometry is interpreted relative to the global screen.
This means that the following string:
100x100+90+2
... will position itself relative from the position of all screens,
rather than the monitor which is the active one.
Fixes #813
When looking up the global monitor, do so via its helper function. Fixes #813
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When interpreting geometry strings, fvwm has an extension to specify a screen name, such as:
This would therefore make the window appear at position
100x100+2+90relative to monitorHDMI-1.Normal X11 geometry strings do not have this monitor specifier -- and in such cases, that geometry should be interpreted relative to the position of all the screens, which is called the global screen.
Without this change in this PR, the geometry was relative to the current screen which is confusing.
Fixes #813
Fixes #810