Skip to content

EWMH: Update SetWorkArea() to use global w/h #840

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 1, 2023
Merged

EWMH: Update SetWorkArea() to use global w/h #840

merged 1 commit into from
Apr 1, 2023

Conversation

ThomasAdam
Copy link
Member

Complete and utter bullshit, but this might just help with multi-monitor
setups.

Fixes #779

@ThomasAdam ThomasAdam added this to the 1.0.7 milestone Mar 30, 2023
@ThomasAdam ThomasAdam self-assigned this Mar 30, 2023
@jnse
Copy link

jnse commented Mar 30, 2023 •
edited
Loading

Looks good... no more menu bug with this change! :shipit:
One note on the comment " * Which will most likely evaluate to 0,0 anyway." - seems like it doesn't for some monitors on my system:

Note the (1117,0) and (0,900) offsets - which seems odd, but still OK - menus seem fine.


NET_WORKAREA(CARDINAL) = 1117, 0, 3840, 1980, 1117, 0, 3840, 1980, 1117, 0, 3840, 1980, 1117, 0, 3840, 1980
_NET_WORKAREA(CARDINAL) = 0, 900, 3840, 1980, 0, 900, 3840, 1980, 0, 900, 3840, 1980, 0, 900, 3840, 1980

@ThomasAdam ThomasAdam force-pushed the ta/gh-779 branch 2 times, most recently from b138479 to f28943a Compare March 31, 2023 22:00
@ThomasAdam
EWMH: Update SetWorkArea() to use global screen
942e6c5 
When computing the NET_WORKAREA, do so from the global screen (total
area), and let that repeat for all desktops defined.

Fixes #779
@ThomasAdam ThomasAdam merged commit 35c6933 into main Apr 1, 2023
@ThomasAdam ThomasAdam deleted the ta/gh-779 branch April 1, 2023 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ThomasAdam ThomasAdam

Labels
None yet
Projects
None yet
Milestone
1.0.7
Development

Successfully merging this pull request may close these issues.

FLTK applications misbehave - menus and dropdown windows unclickable
2 participants
@ThomasAdam @jnse