Add configure option to generate html man pages. #920
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
./configure --enable-htmldoc will now use asciidoctor to build and then install .html versions of the manual pages (with a table of contents) in $FVWM_DATADIR/htmldoc.
63a5def to
b9b4c12
Compare
ThomasAdam
reviewed
Oct 28, 2023
configure.ac
Outdated
| elif test x"$SED" = x ; then | ||
| with_htmldoc="no" | ||
| problem_htmldoc=": No sed found in PATH" | ||
| elif test x"$HAVE_PERL_FOR_DOCS" = x0 ; then |
There was a problem hiding this comment.
Why is this check necessary?
There was a problem hiding this comment.
I just copied the manpage checks, but the second commit removes these perl checks, since the POD is no longer being used.
|
Hi @somiaj Thanks for this -- things looks OK to me. Just not sure about the $SED check. There's perhaps one or two style cleanups I'd recommend, but nothing blocking this to be merged, IMO. If you can just clarify the $SED point, I'll probably merge it later. |
* Convert bin/fvwm-menu-directory.1, bin/fvwm-perllib.1,
and bin/fvwm-menu-xlock.1 to asciidoc files in doc/
so they can be built into html files.
* Add a comment in the POD that the man pages have moved
(though the man pages haven't been generated from the pod since 2009).
* Remove the perl check in the --enable-mandoc and --enable-htmldoc
options, since perl isn't used to build the docs.
* Remove sed checks as well, since SED is no longer used in either
manpage or htmldoc creation.
dd25509 to
055327e
Compare
|
Oh you were talking about the SED check. I removed them for both htmldoc and manpages, I don't see sed being used for either. |
|
Thanks! All merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
./configure --enable-htmldocwill now use asciidoctor to build and then install .html versions of the manual pages (with a table of contents) in$FVWM_DATADIR/htmldoc.