fsm_init: fix implicit function declaration _IceTransNoListen #1032
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A declaration is required for `_IceTransNoListen` to link against libICE. `_IceTransNoListen` is declared in X11/Xtrans/Xtrans.h (`xtrans-dev`) only when configured for libICE by defining the following symbols: `ICE_t` `TRANS_SERVER`. (see [libICE configure.ac](https://gitlab.freedesktop.org/xorg/lib/libice/-/blob/master/configure.ac)) Add a check in configure.ac to determine if the build system has X11/Xtrans/Xtrans.h, and define `ICE_t` and `TRANS_SERVER` if it does. Add a preprocessor step in lib/fsm.c to switch between using Xtrans.h or an extern declaration for the `_IceTransNoListen` symbol depending on whether or not the build system has Xtrans.h. Fixes fvwmorg#1031 Signed-off-by: Kara <33235324+kro-cat@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add a check in configure.ac to determine if the build system has X11/Xtrans/Xtrans.h, and define
ICE_tandTRANS_SERVERif it does.Add a preprocessor step in lib/fsm.c to switch between using Xtrans.h or an extern declaration for the
_IceTransNoListensymbol depending on whether or not the build system has Xtrans.h.Issue number(s)
Fixes Implicit function _IceTransNoListen in fsm.c #1031