SVG: set default width/height if absent #1135
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the librsvg API calls for >=2.52, the newer API of handle_get_intrinsic_size_in_pixels() doesn't set the default width/height of the image if none is supplied. In this case the viewbox attribute of the SVG file can be used to determine the width/height. If the viewbox attribute isn't present the image is not processed further. Fixes #1133
03bf462 to
826c89c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the librsvg API calls for >=2.52, the newer API of
handle_get_intrinsic_size_in_pixels() doesn't set the default
width/height of the image if none is supplied.
In this case, set those to a default value based on that the viewbox attribute suggests.
If that cannot be found, bail.
Fixes #1133