[impurity] Add test to showcase double report on impure static functions

Summary: Currently we're reporting both $static object and wrapper functions which is excessive. Reviewed By: davidpichardie Differential Revision: D60589822 Privacy Context Container: L1208441 fbshipit-source-id: 9cece4013d766fc0ddfbc469d521fed6b7da09eb
facebook · Aug 1, 2024 · 5b8a7b4 · 5b8a7b4
1 parent f1b4d6f
commit 5b8a7b4
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 0 deletions.
diff --git a/infer/tests/codetoanalyze/hack/impurity/basic.hack b/infer/tests/codetoanalyze/hack/impurity/basic.hack
@@ -67,6 +67,13 @@ class Object {
     $obj->a = $i;
   }
 
+  public static function staticParameterFieldWriteImpure(
+    Object $obj,
+    int $i,
+  ): void {
+    $obj->a = $i;
+  }
+
   public function parameterFieldAccessPure(Object $obj): int {
     return $obj->a;
   }

diff --git a/infer/tests/codetoanalyze/hack/impurity/issues.exp b/infer/tests/codetoanalyze/hack/impurity/issues.exp
@@ -2,4 +2,6 @@ basic.hack, Basic::Object.__construct, 0, IMPURE_FUNCTION, no_bucket, ERROR, [Im
 basic.hack, Basic::Object.setImpure, 0, IMPURE_FUNCTION, no_bucket, ERROR, [Impure function Basic::Object.setImpure,parameter `$this.*a` modified here]
 basic.hack, Basic::Object.callImpureImpure, 0, IMPURE_FUNCTION, no_bucket, ERROR, [Impure function Basic::Object.callImpureImpure,when calling `Basic::Object.setImpure` here,parameter `$this.*a` modified here]
 basic.hack, Basic::Object.parameterFieldWriteImpure, 0, IMPURE_FUNCTION, no_bucket, ERROR, [Impure function Basic::Object.parameterFieldWriteImpure,parameter `$obj.*a` modified here]
+basic.hack, Basic::Object$static.staticParameterFieldWriteImpure, 0, IMPURE_FUNCTION, no_bucket, ERROR, [Impure function Basic::Object$static.staticParameterFieldWriteImpure,parameter `$obj.*a` modified here]
+basic.hack, Basic::Object.staticParameterFieldWriteImpure, 0, IMPURE_FUNCTION, no_bucket, ERROR, [Impure function Basic::Object.staticParameterFieldWriteImpure,when calling `Basic::Object$static.staticParameterFieldWriteImpure` here,parameter `$obj.*a` modified here]
 basic.hack, Basic::Object.swapImpure, 0, IMPURE_FUNCTION, no_bucket, ERROR, [Impure function Basic::Object.swapImpure,parameter `$vec.*__infer_model_backing_last_read` modified here]