Skip to content

Conversation

tristanmorgan
Copy link
Member

This removes the tracing functions with the future aim of re-instrumenting with updated libraries. I'm making a draft PR because I'm wanting feedback.

@tristanmorgan tristanmorgan requested a review from a team February 27, 2025 03:14
@aleksraiden
Copy link
Contributor

Awesome!

@aleksraiden
Copy link
Contributor

I think it would be better if we make two separate releases:

  • v1.6.6 with all updates except this PR - a final release with trace functionality enabled
  • v1.6.7 with only this PR - a first release without trace

@aleksraiden
Copy link
Contributor

Hi, is there any news? This PR was important because it made the process of updating dependencies much cleaner.

@tristanmorgan
Copy link
Member Author

Sorry, but this one is parked until I get time to build a replacement. Just removing it would be a breaking change and I don't know home many people depend on the functionality. Similar to this, is trying to use github.com/pires/go-proxyproto to replace github.com/armon/go-proxyproto for the same need to update. Unfortunately there, a test (TestTCPProxyWithProxyProto) is broken and I have not yet determined if the test depends on required behaviour.

@tristanmorgan tristanmorgan force-pushed the untraceable branch 2 times, most recently from 81bc226 to 3293547 Compare June 4, 2025 23:52
@tristanmorgan tristanmorgan force-pushed the untraceable branch 3 times, most recently from 4bc416d to 49491d5 Compare July 28, 2025 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants