Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: make user session timeout configurable by flags #2845

Merged
merged 1 commit into from
Dec 6, 2023
Merged

feat: make user session timeout configurable by flags #2845

merged 1 commit into from
Dec 6, 2023

Conversation

fritx
Copy link
Contributor

@fritx fritx commented Nov 25, 2023

ref: #2753

Description

🚨 Before submitting your PR, please read community, and indicate which issues (in any of the repos) are either fixed or closed by this PR. See GitHub Help: Closing issues using keywords.

  • DO make sure you are requesting to pull a topic/feature/bugfix branch (right side). Don't request your master!
  • DO make sure you are making a pull request against the master branch (left side). Also you should start your branch off our master.
  • DO make sure that File Browser can be successfully built. See builds and development.
  • DO make sure that related issues are opened in other repositories. I.e., the frontend, caddy plugins or the web page need to be updated accordingly.
  • AVOID breaking the continuous integration build.

Further comments

@fritx fritx requested a review from o1egl as a code owner November 25, 2023 13:26
@fritx fritx mentioned this pull request Nov 25, 2023
Merged
hodgesp
hodgesp approved these changes Nov 29, 2023
View reviewed changes
Copy link

@hodgesp hodgesp left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in a local copy, need to update docs I think. For what my review is worth.

@fritx
Copy link
Contributor Author

fritx commented Dec 5, 2023

Tested in a local copy, need to update docs I think. For what my review is worth.

Thanks for you help and test. Which docs need to be updated? I've found that the other flags are not mentioned neither.

@hodgesp
Copy link

hodgesp commented Dec 5, 2023

Tested in a local copy, need to update docs I think. For what my review is worth.

Thanks for you help and test. Which docs need to be updated? I've found that the other flags are not mentioned neither.

I do not know, just a user myself. Maybe a second read-me with the flags and runtime options but most documentation is over on filebrowser.org so there may be a separate repo for that docs site content or use https://github.com/filebrowser/docs

@o1egl o1egl merged commit 391a078 into filebrowser:master Dec 6, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hodgesp hodgesp hodgesp approved these changes

@o1egl o1egl Awaiting requested review from o1egl o1egl is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fritx @hodgesp @o1egl