Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Add windows support to remote config #10997

Draft
wants to merge 71 commits into
base: master
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
71 commits
Select commit Hold shift + click to select a range
467586f
feat: integration of C++ desktop SDK
Lyokone Feb 21, 2023
b4d9126
add windows
Lyokone Mar 6, 2023
153c0d9
add windows
Lyokone Mar 6, 2023
8f19973
add windows
Lyokone Mar 6, 2023
7ffbf8c
add windows
Lyokone Mar 6, 2023
1efb81f
right position for google service file
Lyokone Mar 6, 2023
856a6df
add windows
Lyokone Mar 6, 2023
dca7958
feat: integration of C++ desktop SDK
Lyokone Feb 21, 2023
3ca3848
add windows
Lyokone Mar 6, 2023
73e93e2
add windows
Lyokone Mar 6, 2023
29700ce
add windows
Lyokone Mar 6, 2023
e9c3cbb
add windows
Lyokone Mar 6, 2023
9e7fdcf
right position for google service file
Lyokone Mar 6, 2023
f5517dc
add windows
Lyokone Mar 6, 2023
e1b75ca
feat(core, windows): add windows support to firebase_core
Lyokone Mar 14, 2023
1e9d473
feat(core, windows): update pigeon
Lyokone Mar 14, 2023
a3f796f
feat(core, windows): update pigeon
Lyokone Mar 14, 2023
f40b408
feat(core, windows): update pigeon
Lyokone Mar 14, 2023
eee05da
feat(core, windows): update pigeon
Lyokone Mar 14, 2023
c2a7db6
Merge branch 'feat/cpp' of https://github.com/firebase/flutterfire in…
Lyokone Mar 20, 2023
a8ed44f
feat: merge with main package
Lyokone Mar 20, 2023
a35e3e6
add intializeApp
Lyokone Mar 20, 2023
49dd1fb
initalizeCore
Lyokone Mar 20, 2023
1a5cd02
ready windows
Lyokone Mar 21, 2023
c8ffe08
feat: integration of C++ desktop SDK
Lyokone Feb 21, 2023
f351089
add windows
Lyokone Mar 6, 2023
b231635
add windows
Lyokone Mar 6, 2023
5ba84f8
add windows
Lyokone Mar 6, 2023
226d0db
add windows
Lyokone Mar 6, 2023
b6cb387
right position for google service file
Lyokone Mar 6, 2023
bd34981
add windows
Lyokone Mar 6, 2023
cb2fc58
add windows
Lyokone Mar 6, 2023
25d474e
add windows
Lyokone Mar 6, 2023
37e9e6a
add windows
Lyokone Mar 6, 2023
3e9ed95
feat(core, windows): add windows support to firebase_core
Lyokone Mar 14, 2023
9dd9781
feat(core, windows): update pigeon
Lyokone Mar 14, 2023
276b7cb
feat(core, windows): update pigeon
Lyokone Mar 14, 2023
9c6cbcc
feat(core, windows): update pigeon
Lyokone Mar 14, 2023
6feecbf
feat(core, windows): update pigeon
Lyokone Mar 14, 2023
67621a9
feat: merge with main package
Lyokone Mar 20, 2023
f702e79
add intializeApp
Lyokone Mar 20, 2023
73ce28a
initalizeCore
Lyokone Mar 20, 2023
0999c3e
ready windows
Lyokone Mar 21, 2023
c03cb0d
Merge branch 'feat/cpp' of https://github.com/firebase/flutterfire in…
Lyokone Mar 21, 2023
e203061
app host
Lyokone Mar 21, 2023
33f2580
add licence headers
Lyokone Mar 21, 2023
d90af0d
format
Lyokone Mar 21, 2023
cac387a
format
Lyokone Mar 21, 2023
883cc12
formatting ui
Lyokone Mar 21, 2023
e59e241
formatting ui
Lyokone Mar 21, 2023
b4b4ee4
formatting ui
Lyokone Mar 21, 2023
4314033
feat: automatically download the C++ SDK
Lyokone Mar 24, 2023
26674eb
feat: auto download of the sdk
Lyokone Apr 13, 2023
3986c3f
Add windows to test folder
Lyokone Apr 13, 2023
0e985b3
tests working
Lyokone Apr 13, 2023
bec139f
ci: windows ci
Lyokone Apr 13, 2023
2ae5a11
ci: windows
Lyokone Apr 13, 2023
13a78b0
ci: tests
Lyokone Apr 13, 2023
7852dd8
remove old desktop service files
Lyokone Apr 13, 2023
9131867
add licence
Lyokone Apr 13, 2023
6844729
remove comment
Lyokone Apr 13, 2023
f138fad
remove file
Lyokone Apr 13, 2023
773bcf2
init commit for remote_config windows
cynthiajoan May 17, 2023
1d43636
Merge branch 'feat/cpp' into feat/rc_windows
cynthiajoan May 17, 2023
2df8b1d
Merge https://github.com/firebase/flutterfire into feat/rc_windows
cynthiajoan May 20, 2023
4361fd9
more pigoen change
cynthiajoan May 20, 2023
ac5d4c4
update on the async result handle and more
cynthiajoan May 26, 2023
0e90b9f
fix a compile error
cynthiajoan May 26, 2023
caca4f6
Merge https://github.com/firebase/flutterfire into feat/rc_windows
cynthiajoan Jun 22, 2023
ad3ab0e
hack to create firebaseApp
cynthiajoan Jun 23, 2023
acb2af4
better way to access FirebaseApp and FirebaseRemoteConfig
cynthiajoan Jun 27, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
tests working
  • Loading branch information
Lyokone committed Apr 13, 2023
commit 0e985b3befb016f03b992c42619114b74965b526
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ class DefaultFirebaseOptions {
return ios;
case TargetPlatform.macOS:
return macos;
// TODO(Lyokone): FIX
// TODO(Lyokone): Remove when FlutterFire CLI updated
case TargetPlatform.windows:
return android;
default:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -73,9 +73,7 @@ PigeonFirebaseOptions optionsFromFIROptions(
if (options.database_url() != nullptr) {
pigeon_options.set_database_u_r_l(options.database_url());
}
if (options.ga_tracking_id() != nullptr) {
pigeon_options.set_tracking_id(options.ga_tracking_id());
}
pigeon_options.set_tracking_id(nullptr);
pigeon_options.set_messaging_sender_id(options.messaging_sender_id());
pigeon_options.set_project_id(options.project_id());
if (options.storage_bucket() != nullptr) {
Expand Down
32 changes: 20 additions & 12 deletions tests/integration_test/e2e_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,9 @@
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.

import 'dart:io';

import 'package:flutter/foundation.dart';
import 'package:flutter_test/flutter_test.dart';
import 'package:integration_test/integration_test.dart';

Expand Down Expand Up @@ -31,18 +34,23 @@ void main() {
IntegrationTestWidgetsFlutterBinding.ensureInitialized();

group('FlutterFire', () {
if (kIsWeb || !Platform.isWindows) {
firebase_core.main();
firebase_database.main();
firebase_crashlytics.main();
firebase_auth.main();
firebase_analytics.main();
cloud_functions.main();
firebase_app_check.main();
firebase_app_installations.main();
firebase_dynamic_links.main();
firebase_messaging.main();
firebase_ml_model_downloader.main();
firebase_remote_config.main();
firebase_storage.main();
} else {
// Only tests available on Windows
firebase_core.main();
firebase_database.main();
firebase_crashlytics.main();
firebase_auth.main();
firebase_analytics.main();
cloud_functions.main();
firebase_app_check.main();
firebase_app_installations.main();
firebase_dynamic_links.main();
firebase_messaging.main();
firebase_ml_model_downloader.main();
firebase_remote_config.main();
firebase_storage.main();
}
});
}
2 changes: 2 additions & 0 deletions tests/lib/firebase_options.dart
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,8 @@ class DefaultFirebaseOptions {
return ios;
case TargetPlatform.macOS:
return macos;
case TargetPlatform.windows:
return android;
default:
throw UnsupportedError(
'DefaultFirebaseOptions are not supported for this platform.',
Expand Down
30 changes: 0 additions & 30 deletions tests/test/widget_test.dart

This file was deleted.