Use the double fork method to daemonize jailer #4259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #4259 +/- ##
==========================================
- Coverage 81.72% 81.66% -0.07%
==========================================
Files 240 240
Lines 29266 29288 +22
==========================================
Hits 23917 23917
- Misses 5349 5371 +22
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
pb8o
reviewed
Nov 23, 2023
pb8o
previously approved these changes
Nov 24, 2023
kalyazin
previously approved these changes
Nov 24, 2023
kalyazin
reviewed
Nov 24, 2023
Use the double fork method to daemonize jailer as suggested in https://0xjet.github.io/3OHA/2022/04/11/post.html 1st fork to make sure setsid doesn't fail and 2nd fork is to make sure the daemon code cannot reacquire a controlling terminal. Signed-off-by: Sudan Landge <sudanl@amazon.com>
kalyazin
approved these changes
Nov 24, 2023
pb8o
approved these changes
Nov 24, 2023
3 tasks
This was referenced Feb 9, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
1st fork to make sure setsid doesn't fail and 2nd fork is to
make sure the daemon code cannot reacquire a controlling terminal.
In addition to the CI tried running --daemonize manually as per steps mentioned in #4140 and didn't see the setsid error.
Reason
to start if it was started a process group leader, because setsid()
returns an error if the calling process is already a process group
leader.
This was a common reported issue by users running jailer manually.
Compared to maintaining a document which was rather difficult to
understand and explain, it is easier to handle this case in jailer by not
calling setsid when process id is same as process groud id (i.e. when
jailer is not the process group leader).
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following
Developer Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
[ ] If a specific issue led to this PR, this PR closes the issue.[ ] API changes follow the Runbook for Firecracker API changes.[ ] User-facing changes are mentioned inCHANGELOG.md.[ ] NewTODOs link to an issue.rust-vmm.