chore: test to check if killing microvm works as expected #4436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4436 +/- ##
=======================================
Coverage 81.52% 81.52%
=======================================
Files 241 241
Lines 29296 29296
=======================================
Hits 23883 23883
Misses 5413 5413
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
zulinx86
reviewed
Feb 8, 2024
kalyazin
reviewed
Feb 9, 2024
roypat
reviewed
Feb 9, 2024
zulinx86
previously approved these changes
Feb 9, 2024
roypat
previously approved these changes
Feb 9, 2024
added 2 commits
February 9, 2024 16:36
Change: Add a test to make sure there is no change in behaviour in killing firecracker_pid. Reason: In our CI we pass `--new-pid-ns` along with `--daemonize` and so firecracker pid can be read from the file `firecracker.pid` present in the jailers root directory. However, if there is a change in behaviour that leads to this file not having the actual firecracker pid then it could cause a regression. Signed-off-by: Sudan Landge <sudanl@amazon.com>
da92bf6 commit changed the behaviour of the pid returned by the jailer so, add a known limitation explaining that and suggest a workaround to get the Firecracker pid. Signed-off-by: Sudan Landge <sudanl@amazon.com>
roypat
approved these changes
Feb 9, 2024
zulinx86
approved these changes
Feb 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Add a test to make sure there is no change in behaviour in killing firecracker_pid.
Reason:
In our CI we pass
--new-pid-nsalong with--daemonizeand so firecracker pid can be read from the filefirecracker.pidpresent in the jailers root directory.However, if there is a change in behaviour that leads to this file not having the actual firecracker pid then it could cause a regression.
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
PR.
CHANGELOG.md.TODOs link to an issue.contribution quality standards.
rust-vmm.