Skip to content

Conversation

LukeVader-IV
Copy link
Contributor

@LukeVader-IV LukeVader-IV commented Jul 11, 2025

use the regular install script in docker to ensure that a docker deployment matches a bare-metal one.

this is a patch i applied to the latest release version, it was not tested on the latest code in the repo.

fixes #24

use the regular install script in docker to ensure that a docker deployment matches a bare-metal one.
@LukeVader-IV LukeVader-IV changed the title PATCH: missing docker defauly user PATCH: missing docker default user Jul 15, 2025
@adulau adulau requested a review from DavidCruciani July 28, 2025 09:08
@DavidCruciani
Copy link
Contributor

I'm not sure this is the best solution. The Dockerfile already performs the same steps as install.sh, so running it again would just increase the overall installation time unnecessarily.

Also, removing ./launch.sh -i from install.sh would lead to an incomplete installation for users installing directly from the source.

It's also possible that some errors occurred but went unnoticed because of this line:
RUN script -q -c "./launch.sh --init_db" /dev/null

try:
RUN script -q -c "./launch.sh --init_db"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docker: Default is user unusable
2 participants