Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

firebase-get-to-know-flutter/step_06 needs to dispose pf the textEditingController #115693

Closed
graemep-nz opened this issue Nov 19, 2022 · 7 comments · Fixed by flutter/codelabs#2256
Closed

firebase-get-to-know-flutter/step_06 needs to dispose pf the textEditingController #115693

graemep-nz opened this issue Nov 19, 2022 · 7 comments · Fixed by flutter/codelabs#2256
Assignees
@ericwindmill
Labels
p: firebase Firebase plugins P3 Issues that are less important to the Flutter project team-codelabs Owned by Codelabs team triaged-codelabs Triaged by Codelabs team

Comments

@graemep-nz
Copy link

In this codelab, there needs to be a call to dispose of the textEditingController
https://firebase.google.com/codelabs/firebase-get-to-know-flutter#6

https://github.com/flutter/codelabs/blob/main/firebase-get-to-know-flutter/step_06/lib/main.dart

class _GuestBookState extends State {
final _formKey = GlobalKey(debugLabel: '_GuestBookState');
final _controller = TextEditingController();
@darshankawar darshankawar added in triage Presently being triaged by the triage team team-codelabs Owned by Codelabs team p: firebase Firebase plugins documentation and removed in triage Presently being triaged by the triage team labels Nov 21, 2022
@domesticmouse
Copy link
Contributor

PTAL @ericwindmill

@domesticmouse domesticmouse added the triaged-codelabs Triaged by Codelabs team label Aug 23, 2023
@domesticmouse domesticmouse added the P2 Important issues not at the top of the work list label Sep 14, 2023
@ericwindmill ericwindmill added P3 Issues that are less important to the Flutter project and removed P2 Important issues not at the top of the work list labels Oct 11, 2023
@flutter-triage-bot flutter-triage-bot bot added the ⏳ Bot is counting down the days until it unassigns the issue label Feb 14, 2024
@flutter-triage-bot
Copy link

This issue is assigned to @ericwindmill but has had no recent status updates. Please consider unassigning this issue if it is not going to be addressed in the near future. This allows people to have a clearer picture of what work is actually planned. Thanks!

@domesticmouse
Copy link
Contributor

PTAL @ericwindmill

@flutter-triage-bot flutter-triage-bot bot removed the ⏳ Bot is counting down the days until it unassigns the issue label Feb 19, 2024
@flutter-triage-bot flutter-triage-bot bot added the ⏳ Bot is counting down the days until it unassigns the issue label Jun 24, 2024
@flutter-triage-bot
Copy link

This issue is assigned to @ericwindmill but has had no recent status updates. Please consider unassigning this issue if it is not going to be addressed in the near future. This allows people to have a clearer picture of what work is actually planned. Thanks!

@ericwindmill ericwindmill removed the ⏳ Bot is counting down the days until it unassigns the issue label Jun 25, 2024
@flutter-triage-bot
Copy link

This issue is assigned to @ericwindmill but has had no recent status updates. Please consider unassigning this issue if it is not going to be addressed in the near future. This allows people to have a clearer picture of what work is actually planned. Thanks!

@flutter-triage-bot flutter-triage-bot bot added the ⏳ Bot is counting down the days until it unassigns the issue label Oct 29, 2024
@domesticmouse
Copy link
Contributor

PTAL @ericwindmill

@flutter-triage-bot flutter-triage-bot bot removed the ⏳ Bot is counting down the days until it unassigns the issue label Oct 29, 2024
@ericwindmill ericwindmill mentioned this issue Nov 5, 2024
Merged
@ericwindmill
Copy link

Fixed by flutter/codelabs#2256

domesticmouse pushed a commit to flutter/codelabs that referenced this issue Nov 5, 2024
@ericwindmill
Dispose of TextEditingController in firebase-get-to-know-flutter (#2256)
e438857 
Fixes [#115693 in
flutter/flutter](flutter/flutter#115693)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ericwindmill ericwindmill

Labels
p: firebase Firebase plugins P3 Issues that are less important to the Flutter project team-codelabs Owned by Codelabs team triaged-codelabs Triaged by Codelabs team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Dispose of TextEditingController in firebase-get-to-know-flutter flutter/codelabs
5 participants
@domesticmouse @Hixie @ericwindmill @graemep-nz @darshankawar