-
Notifications
You must be signed in to change notification settings - Fork 27.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Menu buttons MouseRegion
callbacks misfired on Android
#155023
Conversation
044b050
to
6d663ba
Compare
I think this looks reasonable to land in the mean time - will want to make sure we revert when flutter/engine#55157 lands |
Since flutter/engine#55157 is already up. I'll just wait with a goal is to land the test, not the framework fix. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Regression test approved. Lets land the engine fix instead of the framework fix.
|
||
// Check that the menu item is open. | ||
expect(find.text('Menu item'), findsOneWidget); | ||
}, variant: TargetPlatformVariant.only(TargetPlatform.android)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The regression was on android but I dont think this is restricted to a capability of android. Consider running this on all target platforms to prevent regressions there as well.
After the engine fix, this framework test became irrelevant as the test can no longer simulate the framework receiving a wrong flow of events. Closing. |
Fixes SubmenuButton submenus close automatically only on first activation [Android]
Code sample
expand to view the code sample
Before
VID_20240911180435.mp4
After
VID_20240911180401.mp4
Pre-launch Checklist
///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.