Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GlowingOverscrollIndicator examples #155203

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

miechoo
Copy link
Contributor

@miechoo miechoo commented Sep 14, 2024

Part of #130459

This are tests of snippets used in GlowingOverscrollIndicator Flutter API reference documentation.

Since the GlowingOverscrollIndicator is not a standard widget in the widget tree and can not be found using

find.byType()

the tests are using custom NotificationListener to process OverscrollIndicatorNotification events.

Pre-launch Checklist

@github-actions github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: scrolling Viewports, list views, slivers, etc. d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos labels Sep 14, 2024
@miechoo miechoo changed the title 130459 overscroll indicator Missing tests of GlowingOverscrollIndicator Sep 14, 2024
nate-thegrate

This comment was marked as outdated.

@nate-thegrate nate-thegrate marked this pull request as draft September 14, 2024 20:10
@nate-thegrate nate-thegrate marked this pull request as ready for review September 17, 2024 16:32
Copy link
Member

@nate-thegrate nate-thegrate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I went ahead and pushed the example updates to this branch.

We should be good to add tests that look for the GlowingOverscrollIndicator now!

@nate-thegrate nate-thegrate changed the title Missing tests of GlowingOverscrollIndicator Fix GlowingOverscrollIndicator examples Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos f: scrolling Viewports, list views, slivers, etc. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants