Fix the GlowingOverscrollIndicator examples
#155208
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
My guess is that the example was made back in Material 2 days, and default functionality has changed since then. |
|
Committing this directly to the other PR's fork instead 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GlowingOverscrollIndicatorexamples #155203Adding tests for example files has a nice benefit: sometimes you catch a bug in the example!
I noticed that the GlowingOverscrollIndicator examples didn't have a glowing overscroll indicator.
This pull request updates the examples to allow scrolling via click-and-drag and to show a
GlowingOverscrollIndicatorby default.updated example code: https://dartpad.dev/?id=edb521a261a8f52f983dcf5b9fb2a1c4