Fix cursor on hover expand/collapse icon (#155207) #155209
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
There was a problem hiding this comment.
Set ExpansionPanel.canTapOnHeader = true, then hover over the ExpansionPanel header on web, the mouse cursor will change from the "hand" to the usual mouse arrow shape while hovering over the expand/collapse icon.
It would be great if we had a test for this! That way, it won't be possible to factor out the IgnorePointer widget in the future without breaking the test.
Since adding an IgnorePointer is a semantic change to the widget tree, this PR will need tests in order to be approved. (Feel free to take a look at the Tree Hygiene wiki page to see which types of changes do/don't qualify for test exemptions.)
Fix undesirable side effects of your refactor away from my solution during your code review of my PR
Flutter has a very strict code of conduct; disrespecting someone else's work is not tolerated.
I often struggle to find ways to get my point across while maintaining respect & dignity, especially when I feel that the other person is in the wrong. But at the same time, I'm also amazed by everything the Flutter team has been able to do so far. Overall, I think it's important to recognize & appreciate the valuable contributions that others make, rather than drawing attention to mistakes & shortcomings.
Let me know if you have any questions or additional thoughts!
61a6209
to
3457ff1
Compare
When canTapOnHeader true
3457ff1
to
36b637d
Compare
@TahaTesser Fix undesirable side effects of your refactor away from my solution to add
IgnorePointerduring your code review of my PR #147098. I don't have time to implement my whole initial fix a second time, and update the tests that were added to verify your disabled color change. The issue is resolved with only adding the IgnorePointer.See 155207.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.