Added new parameter disabledChildrenInteraction on CarouselView to allow developer to control which part is clickable
#155214
+140
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…action - Modified the InkWell in _buildCarouselItem method to remove tap functionality when widget.onTap is null - This change allows child widgets (e.g., buttons) to maintain their own tap behavior without interference from the CarouselView - Improves usability when CarouselView contains interactive elements - Ensures no unintended splash effects occur on the carousel item when widget.onTap is not provided This update enhances the flexibility of CarouselView, making it more compatible with various types of child widgets while maintaining its core functionality.
|
Mentioning a simple solution just in case #155218 |
You can checked my first commit, I was using onTap at first, but it will break some existing test cases. It may be a breaking change for some existing code. Also, using |
|
@SuicaLondon I think you're right. Should I close my PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
disabledChildrenInteractionparameter toCarouselViewwidgetThis PR addresses issues #155199 and #154701 by adding a new parameter to the CarouselView widget that allows developers to control which parts of the carousel are clickable. Currently, an InkWell covers the entire carousel, preventing child widgets from being clickable even when children widget have their clickable widgets.
The new
disabledChildrenInteractionparameter allows developers to disable this default behavior ofInkWellwithout breaking any existing code. IfdisabledChildrenInteractionisfalse, theonTapof theCarouselViewwill be disabled. And developer can define their own click behavior likes animation ,the clickable widget and so on.I have added some new test cases and passed all of them
///).If you need help, consider asking for advice on the #hackers-new channel on [Discord].