Add optional parameter to FlutterTesterDevices. #158133
Merged
+2
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
|
You can do this, but I think this is better done as a G3Fix when rolling, no? |
matanlurey
requested changes
Nov 4, 2024
|
Polina, any update? |
|
There are issues with G3Fix: b/377380166 |
matanlurey
requested changes
Nov 5, 2024
| @@ -266,6 +266,7 @@ class FlutterTesterDevices extends PollingDeviceDiscovery { | |||
| required Logger logger, | |||
| required FlutterVersion flutterVersion, | |||
| TestCompilerNativeAssetsBuilder? nativeAssetsBuilder, | |||
| // ignore: avoid_unused_constructor_parameters, temporarily unused to prepare G3. | |||
There was a problem hiding this comment.
Do you need to add back the parameter?
matanlurey
approved these changes
Nov 5, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 5, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 5, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 5, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 5, 2024
|
This PR bypassed testing exempt, because it was high priority to re-land PRs. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Nov 5, 2024
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Nov 5, 2024
flutter/flutter@8591d0c...29d40f7 2024-11-05 andrewrkolos@gmail.com increase subsharding for `Windows build_tests` from 8 to 9 (flutter/flutter#158146) 2024-11-05 polinach@google.com Reland2: Revert "Revert "Add a warning/additional handlers for parsing`synthetic-package`."" (flutter/flutter#158184) 2024-11-05 polinach@google.com Reland1: "Revert "Add and plumb `useImplicitPubspecResolution` across `flutter_tools`."" (flutter/flutter#158126) 2024-11-05 engine-flutter-autoroll@skia.org Roll Packages from 796afa3 to 7219431 (11 revisions) (flutter/flutter#158179) 2024-11-05 kustermann@google.com Make native asset integration test more robust, thereby allowing smooth auto-update of packages via `flutter update-packages` (flutter/flutter#158170) 2024-11-05 mohellebiabdessalem@gmail.com Readability change to `flutter.groovy`, align on null assignment, reduce unused scope for some methods, apply static where possible (flutter/flutter#157471) 2024-11-05 engine-flutter-autoroll@skia.org Roll Flutter Engine from 7207a8fbec93 to f56401062e42 (1 revision) (flutter/flutter#158169) 2024-11-05 32538273+ValentinVignal@users.noreply.github.com Add test for `raw_scrollbar.shape.0.dart` (flutter/flutter#158094) 2024-11-05 engine-flutter-autoroll@skia.org Roll Flutter Engine from 418609dd5b58 to 7207a8fbec93 (1 revision) (flutter/flutter#158156) 2024-11-05 bruno.leroux@gmail.com Refactor DropdownMenu tests (flutter/flutter#157913) 2024-11-05 engine-flutter-autoroll@skia.org Roll Flutter Engine from 6271a92a376f to 418609dd5b58 (3 revisions) (flutter/flutter#158152) 2024-11-05 fluttergithubbot@gmail.com Marks Linux_pixel_7pro flavors_test to be flaky (flutter/flutter#156956) 2024-11-05 matanlurey@users.noreply.github.com Further remove web-only considerations that are no longer necessary (flutter/flutter#158143) 2024-11-05 polinach@google.com Add optional parameter to FlutterTesterDevices. (flutter/flutter#158133) 2024-11-05 engine-flutter-autoroll@skia.org Roll Flutter Engine from 75acceedca41 to 6271a92a376f (2 revisions) (flutter/flutter#158148) 2024-11-05 matanlurey@users.noreply.github.com Extract and restore a test that a blank native assets project still builds (flutter/flutter#158141) 2024-11-04 matanlurey@users.noreply.github.com Remove references to the HTML renderer in public docs. (flutter/flutter#158035) 2024-11-04 engine-flutter-autoroll@skia.org Roll Flutter Engine from f880b56b6ede to 75acceedca41 (1 revision) (flutter/flutter#158137) 2024-11-04 nate.w5687@gmail.com Fix `WidgetStateProperty` documentation (flutter/flutter#154298) 2024-11-04 engine-flutter-autoroll@skia.org Roll Flutter Engine from 25c7e471e2ef to f880b56b6ede (5 revisions) (flutter/flutter#158132) 2024-11-04 engine-flutter-autoroll@skia.org Roll Flutter Engine from 05cb5d7f7939 to 25c7e471e2ef (12 revisions) (flutter/flutter#158127) 2024-11-04 737941+loic-sharma@users.noreply.github.com Remove use_modular_headers! from Swift Podfiles (flutter/flutter#156257) 2024-11-04 victorsanniay@gmail.com Disable failing native assets test (flutter/flutter#158119) 2024-11-04 nate.w5687@gmail.com Fix `NestedScrollView` inner position logic (flutter/flutter#157756) 2024-11-04 jacksongardner@google.com Add benchmarks for single-threaded Skwasm. (flutter/flutter#158027) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC camillesimon@google.com,stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to handle Google testing failures for #158126.
We want to update G3 to provide this parameter before merging the full change.
Testing is not needed because the change is no-op.