Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump dartdoc to 7.0.1 and clean-up #136975

Merged
merged 5 commits into from
Oct 20, 2023
Merged

Bump dartdoc to 7.0.1 and clean-up #136975

merged 5 commits into from
Oct 20, 2023

Conversation

goderbauer
Copy link
Member

@goderbauer goderbauer commented Oct 20, 2023

These warnings/errors have been removed from dartdoc. Removing them from the flutter config as well.

Also fixes CI to actually test doc generation for all documented packages and on dartdoc config changes.

@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie or stuartmorgan on the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Copy link
Contributor

@gspencergoog gspencergoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

32384589-a60f0e74-c078-11e7-9bc1-e5b5287aea9d

@goderbauer goderbauer changed the title Update dartdoc_options.yaml Bump dartdoc to 7.0.1 and clean-up Oct 20, 2023
@goderbauer goderbauer added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 20, 2023
@auto-submit auto-submit bot merged commit 997a94f into master Oct 20, 2023
130 checks passed
@auto-submit auto-submit bot deleted the goderbauer-patch-1 branch October 20, 2023 22:13
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 21, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 21, 2023
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Oct 21, 2023
flutter/flutter@0883cb2...6f4850d

2023-10-21 engine-flutter-autoroll@skia.org Roll Flutter Engine from a12116df3859 to 11f87dce1017 (1 revision) (flutter/flutter#137017)
2023-10-21 engine-flutter-autoroll@skia.org Roll Flutter Engine from 755c477c96e7 to a12116df3859 (1 revision) (flutter/flutter#137013)
2023-10-21 engine-flutter-autoroll@skia.org Roll Flutter Engine from 4f9f4013c3b3 to 755c477c96e7 (1 revision) (flutter/flutter#137008)
2023-10-21 41873024+droidbg@users.noreply.github.com Test cover painting for memory leaks (flutter/flutter#136696)
2023-10-21 engine-flutter-autoroll@skia.org Roll Flutter Engine from 2e5fb647a76f to 4f9f4013c3b3 (2 revisions) (flutter/flutter#136999)
2023-10-21 engine-flutter-autoroll@skia.org Roll Flutter Engine from e4fc0c4e2b97 to 2e5fb647a76f (3 revisions) (flutter/flutter#136995)
2023-10-21 engine-flutter-autoroll@skia.org Roll Flutter Engine from 9796817fb6e2 to e4fc0c4e2b97 (1 revision) (flutter/flutter#136993)
2023-10-20 engine-flutter-autoroll@skia.org Roll Flutter Engine from 4a65910f0ab2 to 9796817fb6e2 (2 revisions) (flutter/flutter#136990)
2023-10-20 47866232+chunhtai@users.noreply.github.com Adds more a11y use cases (flutter/flutter#136761)
2023-10-20 1961493+harryterkelsen@users.noreply.github.com Reland "Use Layer.toImage for golden tests on CanvasKit" (flutter/flutter#136918)
2023-10-20 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 2.22.3 to 2.22.4 (flutter/flutter#136985)
2023-10-20 robert.ancell@canonical.com Add missing call to parent method of GApplication::shutdown, implement GApplication::startup (flutter/flutter#136836)
2023-10-20 engine-flutter-autoroll@skia.org Roll Flutter Engine from b27e1b38375b to 4a65910f0ab2 (5 revisions) (flutter/flutter#136987)
2023-10-20 goderbauer@google.com Bump dartdoc to 7.0.1 and clean-up (flutter/flutter#136975)
2023-10-20 31859944+LongCatIsLooong@users.noreply.github.com RenderEditable WidgetSpan intrinsics (flutter/flutter#136979)
2023-10-20 engine-flutter-autoroll@skia.org Roll Flutter Engine from d46933e6772e to b27e1b38375b (9 revisions) (flutter/flutter#136982)
2023-10-20 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#136924)
2023-10-20 kevinjchisholm@google.com [docs] Expand categories for automated release notes (flutter/flutter#136967)
2023-10-20 engine-flutter-autoroll@skia.org Roll Flutter Engine from 21b5c3771ee1 to d46933e6772e (3 revisions) (flutter/flutter#136973)
2023-10-20 jonahwilliams@google.com [Impeller] add OpenGL GPU tracing to devicelab tests. (flutter/flutter#136974)
2023-10-20 engine-flutter-autoroll@skia.org Roll Flutter Engine from f9d1dbc39f4c to 21b5c3771ee1 (1 revision) (flutter/flutter#136969)
2023-10-20 dacoharkes@google.com Default `NativeAssets` Darwin and IOS target archs if missing (flutter/flutter#136948)
2023-10-20 engine-flutter-autoroll@skia.org Roll Flutter Engine from 6d1e9eec0841 to f9d1dbc39f4c (1 revision) (flutter/flutter#136966)
2023-10-20 engine-flutter-autoroll@skia.org Roll Flutter Engine from 9b88ff83fd82 to 6d1e9eec0841 (2 revisions) (flutter/flutter#136965)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC rmistry@google.com,stuartmorgan@google.com,tarrinneal@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@Hixie
Copy link
Contributor

Hixie commented Oct 21, 2023

test-exempt: rolling dependency

@goderbauer goderbauer mentioned this pull request Oct 23, 2023
Copy link
Contributor

@srawlins srawlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

auto-submit bot pushed a commit that referenced this pull request Oct 23, 2023
HugoOlthof pushed a commit to moneybird/packages that referenced this pull request Dec 13, 2023
flutter/flutter@0883cb2...6f4850d

2023-10-21 engine-flutter-autoroll@skia.org Roll Flutter Engine from a12116df3859 to 11f87dce1017 (1 revision) (flutter/flutter#137017)
2023-10-21 engine-flutter-autoroll@skia.org Roll Flutter Engine from 755c477c96e7 to a12116df3859 (1 revision) (flutter/flutter#137013)
2023-10-21 engine-flutter-autoroll@skia.org Roll Flutter Engine from 4f9f4013c3b3 to 755c477c96e7 (1 revision) (flutter/flutter#137008)
2023-10-21 41873024+droidbg@users.noreply.github.com Test cover painting for memory leaks (flutter/flutter#136696)
2023-10-21 engine-flutter-autoroll@skia.org Roll Flutter Engine from 2e5fb647a76f to 4f9f4013c3b3 (2 revisions) (flutter/flutter#136999)
2023-10-21 engine-flutter-autoroll@skia.org Roll Flutter Engine from e4fc0c4e2b97 to 2e5fb647a76f (3 revisions) (flutter/flutter#136995)
2023-10-21 engine-flutter-autoroll@skia.org Roll Flutter Engine from 9796817fb6e2 to e4fc0c4e2b97 (1 revision) (flutter/flutter#136993)
2023-10-20 engine-flutter-autoroll@skia.org Roll Flutter Engine from 4a65910f0ab2 to 9796817fb6e2 (2 revisions) (flutter/flutter#136990)
2023-10-20 47866232+chunhtai@users.noreply.github.com Adds more a11y use cases (flutter/flutter#136761)
2023-10-20 1961493+harryterkelsen@users.noreply.github.com Reland "Use Layer.toImage for golden tests on CanvasKit" (flutter/flutter#136918)
2023-10-20 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 2.22.3 to 2.22.4 (flutter/flutter#136985)
2023-10-20 robert.ancell@canonical.com Add missing call to parent method of GApplication::shutdown, implement GApplication::startup (flutter/flutter#136836)
2023-10-20 engine-flutter-autoroll@skia.org Roll Flutter Engine from b27e1b38375b to 4a65910f0ab2 (5 revisions) (flutter/flutter#136987)
2023-10-20 goderbauer@google.com Bump dartdoc to 7.0.1 and clean-up (flutter/flutter#136975)
2023-10-20 31859944+LongCatIsLooong@users.noreply.github.com RenderEditable WidgetSpan intrinsics (flutter/flutter#136979)
2023-10-20 engine-flutter-autoroll@skia.org Roll Flutter Engine from d46933e6772e to b27e1b38375b (9 revisions) (flutter/flutter#136982)
2023-10-20 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#136924)
2023-10-20 kevinjchisholm@google.com [docs] Expand categories for automated release notes (flutter/flutter#136967)
2023-10-20 engine-flutter-autoroll@skia.org Roll Flutter Engine from 21b5c3771ee1 to d46933e6772e (3 revisions) (flutter/flutter#136973)
2023-10-20 jonahwilliams@google.com [Impeller] add OpenGL GPU tracing to devicelab tests. (flutter/flutter#136974)
2023-10-20 engine-flutter-autoroll@skia.org Roll Flutter Engine from f9d1dbc39f4c to 21b5c3771ee1 (1 revision) (flutter/flutter#136969)
2023-10-20 dacoharkes@google.com Default `NativeAssets` Darwin and IOS target archs if missing (flutter/flutter#136948)
2023-10-20 engine-flutter-autoroll@skia.org Roll Flutter Engine from 6d1e9eec0841 to f9d1dbc39f4c (1 revision) (flutter/flutter#136966)
2023-10-20 engine-flutter-autoroll@skia.org Roll Flutter Engine from 9b88ff83fd82 to 6d1e9eec0841 (2 revisions) (flutter/flutter#136965)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC rmistry@google.com,stuartmorgan@google.com,tarrinneal@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants