Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed deprecated NavigatorState.focusScopeNode #139260

Merged
merged 1 commit into from
Dec 5, 2023
Merged

Removed deprecated NavigatorState.focusScopeNode #139260

merged 1 commit into from
Dec 5, 2023

Conversation

Piinks
Copy link
Contributor

@Piinks Piinks commented Nov 29, 2023

Part of #139243

Deprecated in #109702

The replacement for focusScopeNode is focusNode.enclosingScope

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@Piinks Piinks added framework flutter/packages/flutter repository. See also f: labels. c: API break Backwards-incompatible API changes c: tech-debt Technical debt, code quality, testing, etc. labels Nov 29, 2023
@Piinks Piinks marked this pull request as draft November 29, 2023 20:58
@github-actions github-actions bot added the f: routes Navigator, Router, and related APIs. label Nov 29, 2023
@Piinks
Copy link
Contributor Author

Piinks commented Nov 29, 2023

Marked as a draft since there are a few more internal uses I am cleaning up.

@Piinks Piinks marked this pull request as ready for review December 4, 2023 22:53
gspencergoog
gspencergoog approved these changes Dec 4, 2023
View reviewed changes
Copy link
Contributor

@gspencergoog gspencergoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

32384589-a60f0e74-c078-11e7-9bc1-e5b5287aea9d

packages/flutter/lib/fix_data/fix_widgets/fix_widgets.yaml
@@ -23,6 +23,17 @@
# * ListWheelScrollView: fix_list_wheel_scroll_view.yaml
version: 1
transforms:
# Changes made in TBD
- title: "Migrate to focusNode.enclosingScope!"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The "!" makes for a much more exciting title. :-)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does! :)

@Piinks Piinks added the autosubmit Merge PR when tree becomes green via auto submit App label Dec 5, 2023
@auto-submit auto-submit bot merged commit 4040570 into flutter:master Dec 5, 2023
70 checks passed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 5, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 5, 2023
@engine-flutter-autoroll
4040570 Removed deprecated NavigatorState.focusScopeNode (flutter/flu…
8442679 
…tter#139260)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 6, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 6, 2023
@engine-flutter-autoroll
4040570 Removed deprecated NavigatorState.focusScopeNode (flutter/flu…
a66916d 
…tter#139260)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 6, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 6, 2023
@engine-flutter-autoroll
4040570 Removed deprecated NavigatorState.focusScopeNode (flutter/flu…
2cf9e82 
…tter#139260)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 6, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 6, 2023
@engine-flutter-autoroll
4040570 Removed deprecated NavigatorState.focusScopeNode (flutter/flu…
b327aa7 
…tter#139260)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 6, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 6, 2023
@engine-flutter-autoroll
4040570 Removed deprecated NavigatorState.focusScopeNode (flutter/flu…
bbcf657 
…tter#139260)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 6, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 6, 2023
@engine-flutter-autoroll
4040570 Removed deprecated NavigatorState.focusScopeNode (flutter/flu…
ce812d0 
…tter#139260)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 6, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 6, 2023
@engine-flutter-autoroll
4040570 Removed deprecated NavigatorState.focusScopeNode (flutter/flu…
19b41a5 
…tter#139260)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 7, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 7, 2023
@engine-flutter-autoroll
4040570 Removed deprecated NavigatorState.focusScopeNode (flutter/flu…
c60efe5 
…tter#139260)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 7, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 7, 2023
@engine-flutter-autoroll
4040570 Removed deprecated NavigatorState.focusScopeNode (flutter/flu…
c7300f2 
…tter#139260)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 7, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 7, 2023
@engine-flutter-autoroll
4040570 Removed deprecated NavigatorState.focusScopeNode (flutter/flu…
82fd268 
…tter#139260)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 7, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 7, 2023
@engine-flutter-autoroll
4040570 Removed deprecated NavigatorState.focusScopeNode (flutter/flu…
ac2bfe9 
…tter#139260)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 7, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 7, 2023
@engine-flutter-autoroll
4040570 Removed deprecated NavigatorState.focusScopeNode (flutter/flu…
6fcee2f 
…tter#139260)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 7, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 7, 2023
@engine-flutter-autoroll
4040570 Removed deprecated NavigatorState.focusScopeNode (flutter/flu…
b489017 
…tter#139260)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 8, 2023
@engine-flutter-autoroll
4040570 Removed deprecated NavigatorState.focusScopeNode (flutter/flu…
0821471 
…tter#139260)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 8, 2023
@engine-flutter-autoroll
4040570 Removed deprecated NavigatorState.focusScopeNode (flutter/flu…
07d0782 
…tter#139260)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 8, 2023
@engine-flutter-autoroll
4040570 Removed deprecated NavigatorState.focusScopeNode (flutter/flu…
38f5e1f 
…tter#139260)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 8, 2023
@engine-flutter-autoroll
4040570 Removed deprecated NavigatorState.focusScopeNode (flutter/flu…
6980cf6 
…tter#139260)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 8, 2023
@engine-flutter-autoroll
4040570 Removed deprecated NavigatorState.focusScopeNode (flutter/flu…
16957cb 
…tter#139260)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 8, 2023
@engine-flutter-autoroll
4040570 Removed deprecated NavigatorState.focusScopeNode (flutter/flu…
b22808e 
…tter#139260)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 8, 2023
@engine-flutter-autoroll
4040570 Removed deprecated NavigatorState.focusScopeNode (flutter/flu…
3080d92 
…tter#139260)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 8, 2023
@engine-flutter-autoroll
4040570 Removed deprecated NavigatorState.focusScopeNode (flutter/flu…
255bcd5 
…tter#139260)
@HansMuller HansMuller mentioned this pull request Dec 15, 2023
Open
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 16, 2024
@engine-flutter-autoroll
4040570 Removed deprecated NavigatorState.focusScopeNode (flutter/flu…
3e8e49a 
…tter#139260)
TahaTesser
TahaTesser reviewed Sep 12, 2024
View reviewed changes
packages/flutter/lib/fix_data/fix_widgets/fix_widgets.yaml
@@ -23,6 +23,17 @@
# * ListWheelScrollView: fix_list_wheel_scroll_view.yaml
version: 1
transforms:
# Changes made in TBD
Copy link
Member

@TahaTesser TahaTesser Sep 12, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed some TBDs that are carried forward and merged, when working on #155072.

@TahaTesser TahaTesser mentioned this pull request Sep 12, 2024
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TahaTesser TahaTesser TahaTesser left review comments

@gspencergoog gspencergoog gspencergoog approved these changes

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App c: API break Backwards-incompatible API changes c: tech-debt Technical debt, code quality, testing, etc. f: routes Navigator, Router, and related APIs. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Piinks @gspencergoog @TahaTesser