-
Notifications
You must be signed in to change notification settings - Fork 27.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump dartdoc to 0.34.0 #66048
Merged
Merged
Bump dartdoc to 0.34.0 #66048
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter-dashboard
bot
added
the
team
Infra upgrades, team productivity, code health, technical debt. See also team: labels.
label
Sep 17, 2020
goderbauer
force-pushed
the
bumpDartDocs34
branch
from
September 17, 2020 18:45
c7d1ed5
to
96b91b5
Compare
/cc @srawlins |
Piinks
approved these changes
Sep 17, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Gold has detected about 9 untriaged digest(s) on patchset 2. |
The gold results are confusing. Gold was disabled by an infra change, so these images do not appear related. |
goderbauer
force-pushed
the
bumpDartDocs34
branch
from
September 17, 2020 20:13
96b91b5
to
bf34126
Compare
Love it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
d: api docs
Issues with https://api.flutter.dev/
team
Infra upgrades, team productivity, code health, technical debt. See also team: labels.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Bump dartdoc to latest version and make newly introduced warnings fatal.
Related Issues
n/a
Tests
I added the following tests:
n/a
Checklist
Before you create this PR, confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]
). This will ensure a smooth and quick review process.///
).flutter analyze --flutter-repo
) does not report any problems on my PR.Breaking Change
Did any tests fail when you ran them? Please read Handling breaking changes.