Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump dartdoc to 0.34.0 #66048

Merged
merged 3 commits into from
Sep 22, 2020
Merged

Bump dartdoc to 0.34.0 #66048

merged 3 commits into from
Sep 22, 2020

Conversation

goderbauer
Copy link
Member

@goderbauer goderbauer commented Sep 17, 2020

Description

Bump dartdoc to latest version and make newly introduced warnings fatal.

Related Issues

n/a

Tests

I added the following tests:

n/a

Checklist

Before you create this PR, confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Did any tests fail when you ran them? Please read Handling breaking changes.

@flutter-dashboard flutter-dashboard bot added the team Infra upgrades, team productivity, code health, technical debt. See also team: labels. label Sep 17, 2020
@goderbauer
Copy link
Member Author

/cc @srawlins

@Piinks Piinks added d: api docs Issues with https://api.flutter.dev/ documentation labels Sep 17, 2020
Copy link
Contributor

@Piinks Piinks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@skia-gold
Copy link

Gold has detected about 9 untriaged digest(s) on patchset 2.
View them at https://flutter-gold.skia.org/cl/github/66048

@Piinks
Copy link
Contributor

Piinks commented Sep 17, 2020

The gold results are confusing. Gold was disabled by an infra change, so these images do not appear related.

@srawlins
Copy link
Contributor

Love it

@goderbauer goderbauer merged commit 923eb76 into flutter:master Sep 22, 2020
@goderbauer goderbauer deleted the bumpDartDocs34 branch September 22, 2020 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
d: api docs Issues with https://api.flutter.dev/ team Infra upgrades, team productivity, code health, technical debt. See also team: labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants