Remove ASG migration parameter from commercial deployment
#28272
+0
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arelra
approved these changes
Oct 6, 2025
fbb1d04 to
3de9d20
Compare
3de9d20 to
cdb7868
Compare
|
Seen on ADMIN-PROD (merged by @jamesmockett 16 minutes and 37 seconds ago)
|
|
Seen on FRONTS-PROD (merged by @jamesmockett 16 minutes and 56 seconds ago)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the value of this and can you measure success?
This should be merged immediately following removal of the legacy
commercialinfrastructure (https://github.com/guardian/platform/pull/2028). Once that has been done we will no longer be dual-stackingcommercialand have a single ASG again. We need to remove the ASG migration parameter so that Riff-Raff is no longer trying to update two ASGs which would breakdotcom:frontend-alldeployments.