Skip to content

Fix issue where wrong GCHP grid boxes were being looked up in models vs. obs plots #240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jul 27, 2023
Merged

Fix issue where wrong GCHP grid boxes were being looked up in models vs. obs plots #240

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
ac112eb
Ensure closest grid box indices to stations are returned as integers
yantosca Jul 25, 2023
771f7d7
Change models vs. obs. plots directory name to "ModelVsObs"
yantosca Jul 25, 2023
46e405d
Merge branch 'dev' into bugfix/model-vs-obs-plots
yantosca Jul 25, 2023
34ca217
Add verify_variable_type function to util.py
yantosca Jul 27, 2023
501a9a7
Pass tuples instead of lists to verify_variable_type
yantosca Jul 27, 2023
04d0143
Use cstools functions in benchmark_models_vs_obs.py
yantosca Jul 27, 2023
3e51cee
Minor updates in grid.py and util.py
yantosca Jul 27, 2023
5264eeb
Updated CHANGELOG.md for latest models vs. obs new features
yantosca Jul 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,9 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
- Added `benchmark/modules/GC_72_vertical_levels.csv` file
- Added `multi_index_lat` keyword to `reshape_MAPL_CS` function in `gcpy/util.py`
- Added FURA to `emission_species.yml` and `benchmark_categories.yml`
- Added new routine `format_number_for_table` in `util.py`
- Added new routine `format_number_for_table` in `gcpy/util.py`
- Added module `gcpy/cstools.py` with utility functions for cubed-sphere grids
- Added new routine `verify_variable_type` function in `gcpy/util.py`

### Changed
- Simplified the Github issues templates into two options: `new-feature-or-discussion.md` and `question-issue.md`
Expand All @@ -41,7 +42,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
### Fixed
- Generalized test for GCHP or GCClassic restart file in `regrid_restart_file.py`
- Fixed bug in transport tracer benchmark mass conservation table file write
- Routine `create_display _name` now splits on only the first `_` in species & diag names
- Routine `create_display_name` now splits on only the first `_` in species & diag names

### Removed
- Removed `gchp_is_pre_13_1` arguments & code from benchmarking routines
Expand Down
Loading