Make benchmark configuration files consistent #264
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
msulprizio
commented
Sep 22, 2023
- Fixed comments so they are consistent in gcpy/benchmark/config/*.yml
- Changed default gchp resolution to c24
- Set gchp switch is_pre_14.0: False by default
- Fixed comments so they are consistent in gcpy/benchmark/config/*.yml - Changed default gchp resolution to c24 - Set gchp switch is_pre_14.0: False by default Signed-off-by: Melissa Sulprizio <mpayer@seas.harvard.edu>
yantosca
requested changes
Sep 22, 2023
There was a problem hiding this comment.
Thanks @msulprizio! Everything here looks good but I have a couple of minor requests:
- Also update comments etc. in the
benchmark/cloud/template*.ymlfiles accordingly - Also include a changelog update.
- Updated cloud/template.*_benchmark.yml files as well - Removed & from first line in config/*_benchmark.yml files - Removed whitespace Signed-off-by: Melissa Sulprizio <mpayer@seas.harvard.edu>
yantosca
approved these changes
Oct 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.