Skip to content

file_regrid.py now uses DELP_DRY for delta-dry pressure variable name when creating GCHP files #297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 1, 2024
Merged

file_regrid.py now uses DELP_DRY for delta-dry pressure variable name when creating GCHP files #297

merged 2 commits into from
Feb 1, 2024

Conversation

yantosca
Copy link
Contributor

@yantosca yantosca commented Feb 1, 2024

Name and Institution (Required)

Name: Bob Yantosca
Institution: Harvard + GCST

Confirm you have reviewed the following documentation

Describe the update

This is the companion PR to #296. We have fixed a logic error that caused file_regrid.py to use the wrong variable name DELPDRY insstead of DELP_DRY when regridding to GCHP output files.

Expected changes

Doing the following commands:

$ python -m gcpy.file_regrid --filein GEOSChem.Restart.20190101_0000z.nc4 \
       --dim_format_in classic \
       --fileout GEOSChem.Restart.20190101_0000z.c24.nc4 \
       --cs_res_out 24 \
       --dim_format_out checkpoint
$ ncdump -cts GEOSChem.Restart.20190101_0000z.c24.nc4 | grep "DELP"

Now results in this output:

        float DELP_DRY(time, lev, lat, lon) ;
                DELP_DRY:_FillValue = NaNf ;
                DELP_DRY:long_name = "Delta-pressure across grid box (dry air)" ;
                DELP_DRY:units = "hPa" ;
                DELP_DRY:averaging_method = "instantaneous" ;
                DELP_DRY:_Storage = "chunked" ;
                DELP_DRY:_ChunkSizes = 1, 72, 144, 24 ;
                DELP_DRY:_Endianness = "little" ;

Related Github Issue(s)

@yantosca
Bug fix: file_regrid.py now uses "DELP_DRY" in GCHP output files
8106df7 
gcpy/file_regrid.py
- Fixed a logic error that caused GCHP output files to use the wrong
  file name for delta dry pressure ("DELPDRY" instead of "DELP_DRY").

CHANGELOG.md
- Updated accordingly

Signed-off-by: Bob Yantosca <yantosca@seas.harvard.edu>
@yantosca yantosca added topic: Benchmark Plots and Tables Issues pertaining to generating plots/tables from benchmark output topic: Regridding Issues pertaining to horizontal & vertical regridding category: Bug Fix Fixes a bug that was previously reported labels Feb 1, 2024
@yantosca yantosca added this to the 1.4.3 milestone Feb 1, 2024
@yantosca yantosca requested a review from lizziel February 1, 2024 17:18
@yantosca yantosca self-assigned this Feb 1, 2024
@yantosca yantosca changed the base branch from main to dev February 1, 2024 17:19
@yantosca
Remove "runs" YAML tags from .github/workflows/codeql.yml
af5846f 
This was causing the CodeQL GitHub Action not to run properly.

Signed-off-by: Bob Yantosca <yantosca@seas.harvard.edu>
lizziel
lizziel approved these changes Feb 1, 2024
View reviewed changes
Copy link
Contributor

@lizziel lizziel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@yantosca Octobox
Copy link
Contributor Author

yantosca commented Feb 1, 2024

Thanks @lizziel!

@yantosca yantosca merged commit 73d5628 into dev Feb 1, 2024
@yantosca yantosca deleted the bugfix/file-regrid-delp-dry branch February 1, 2024 18:50
@yantosca yantosca mentioned this pull request Feb 1, 2024
Closed
3 tasks
@yantosca yantosca modified the milestones: 1.4.3, 1.5.0 Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lizziel lizziel lizziel approved these changes

Assignees

@yantosca yantosca

Labels
category: Bug Fix Fixes a bug that was previously reported topic: Benchmark Plots and Tables Issues pertaining to generating plots/tables from benchmark output topic: Regridding Issues pertaining to horizontal & vertical regridding
Projects
None yet
Milestone
1.5.0
Development

Successfully merging this pull request may close these issues.

file_regrid.py creates GCHP restart files with variable name DELPDRY instead of DELP_DRY
2 participants
@yantosca @lizziel