Replace whitespace in Ref and Dev version labels in benchmarking code #340
+134
−32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gcpy/benchmark/modules/benchmark_drydep.py
- Import "get_common_varnames" from benchmark_utils.py
(suggested by Pylint)
- Call util.replace_whitespace on refstr and devstr
gcpy/benchmark/modules/benchmark_funcs.py
- Import replace_whitespace from gcpy.util module
- Call replace_whitespace on refstr and devstr in several routines
- Update comments
gcpy/benchmark/modules/benchmark_gcclassic_stats.py
gcpy/benchmark/modules/benchmark_mass_cons_table.py
gcpy/benchmark/modules/benchmark_models_vs_sondes.py
gcpy/benchmark/modules/benchmark_scrape_gcclassic_timers.py
gcpy/benchmark/modules/benchmark_scrape_gchp_timers.py
gcpy/benchmark/modules/oh_metrics.py
- Import replace_whitespace from gcpy.util module
- Call replace_whitespace on ref_label and dev_label
gcpy/benchmark/modules/benchmark_models_vs_obs.py
- Import replace_whitespace from gcpy.util module
- Call replace_whitespace on ref_label and dev_label
- Initialize lon, lat, alt to zero (suggested by Pylint)
- Align { } brackets
gcpy/benchmark/modules/budget_ox.py
- Move import gc higher in the list (suggested by Pylint)
- Now use "from gcpy import constants" (suggested by Pylint)
- Import replace_whitespace from gcpy.util module
- Call replace_whitespace on devstr
- Trim trailing whitespace (suggested by Pylint)
gcpy/benchmark/modules/budget_tt.py
- Move import gc higher in the list (suggested by Pylint)
- Now use "from gcpy import constants" (suggested by Pylint)
- Now use "from gcpy import util" (suggested by Pylint)
- Remove "from glob import glob" (suggested by Pylint)
- Call util.replace_whitespace on devstr
- Trim trailing whitespace (suggested by Pylint)
gcpy/benchmark/modules/budget_ox.py
- Move import gc higher in the list (suggested by Pylint)
- Now use "from gcpy import constants" (suggested by Pylint)
- Import replace_whitespace from gcpy.util module
- Call replace_whitespace on devstr
- Trim trailing whitespace (suggested by Pylint)
gcpy/benchmark/modules/ste_flux.py
- Call util.replace_whitespace on devstr
CHANGELOG.md
- Updated accordingly
Signed-off-by: Bob Yantosca <yantosca@seas.harvard.edu>
Closed
1 task
msulprizio
approved these changes
Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Name and Institution (Required)
Name: Bob Yantosca
Institution: Harvard + GCST
Describe the update
This is the companion PR to #316. We have updated the benchmarking codes in
gcpy/benchmark/modules/*(as described in commit cbee385) so that we now call theutil.replace_whitespacefunction on the Ref and Dev version labels and in output file names.We have also made minor changes (trimming whitespace, etc) suggested by Pylint.
Expected changes
If a user specifies e.g. version labels such as:
then these will be printed out as
Related Github Issue