Skip to content

Conversation

yosriady
Copy link
Contributor

@yosriady yosriady commented Sep 2, 2025

No description provided.

Copy link

linear bot commented Sep 2, 2025

@yosriady yosriady requested a review from Copilot September 2, 2025 08:50
Copilot

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

@yosriady yosriady requested a review from Copilot September 2, 2025 10:26
Copilot

This comment was marked as outdated.

@yosriady yosriady requested a review from Copilot September 2, 2025 11:13
Copilot

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

@yosriady yosriady requested a review from Copilot September 2, 2025 13:21
Copilot

This comment was marked as outdated.

@yosriady yosriady requested a review from Copilot September 2, 2025 15:46
Copilot

This comment was marked as outdated.

@yosriady yosriady requested a review from Copilot September 4, 2025 07:39
@yosriady yosriady marked this pull request as ready for review September 4, 2025 07:40
Copilot

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

@yosriady yosriady requested a review from Copilot September 4, 2025 08:21
Copilot

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

@yosriady yosriady requested a review from Copilot September 7, 2025 06:42
Copilot

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

Copilot

This comment was marked as outdated.

@yosriady yosriady requested a review from Copilot September 8, 2025 05:05
cursor[bot]

This comment was marked as outdated.

Copilot

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

@yosriady yosriady requested a review from Copilot September 8, 2025 05:36
Copilot

This comment was marked as outdated.

@yosriady yosriady requested a review from Copilot September 8, 2025 06:20
Copilot

This comment was marked as outdated.

@yosriady yosriady changed the title [P-1205] Consent management (WIP) [P-1205] Feature: Added Consent management Sep 8, 2025
@yosriady yosriady requested a review from Copilot September 8, 2025 06:41
Copilot

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

@yosriady yosriady requested a review from Copilot September 8, 2025 07:08
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements consent management functionality to allow users to opt out of tracking while continuing to use the SDK. The feature adds blocked address filtering to prevent events from special addresses like zero and dead addresses.

Key changes:

  • Adds consent management methods for opting in/out of tracking with persistent cookie storage
  • Implements address blocking functionality to filter out events from zero and dead addresses
  • Introduces secure hashing utility for privacy-preserving storage keys

Reviewed Changes

Copilot reviewed 15 out of 15 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
src/FormoAnalytics.ts Adds consent management methods and integrates consent checking into tracking logic
src/lib/consent.ts New consent management utilities with project-specific cookie handling
src/utils/hash.ts New secure hashing utility for creating short, consistent identifiers
src/utils/address.ts Adds isBlockedAddress function to filter out special addresses
src/lib/event/EventManager.ts Integrates blocked address checking to prevent events from blocked addresses
src/constants/base.ts Defines blocked addresses and consent management constants
test/utils/address.spec.ts Comprehensive tests for the new isBlockedAddress functionality

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@yosriady yosriady merged commit 7374bb4 into main Sep 8, 2025
6 checks passed
@yosriady yosriady deleted the p-1205 branch September 8, 2025 07:18
Copy link

github-actions bot commented Sep 8, 2025

🎉 This PR is included in version 1.20.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant