Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional Date Ranges for DateRangeParameter #6894

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

rohithsebastian
Copy link

What type of PR is this?

  • Refactor
  • Feature
  • Bug Fix
  • New Query Runner (Data Source)
  • New Alert Destination
  • Other

Description

Additional dynamic date ranges for time-based filtering using the DateRangeParameter component.

How is this tested?

  • Unit tests (pytest, jest)
  • E2E Tests (Cypress)
  • Manually
  • N/A

Created new Date Range parameter with new query

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings (if there are UI changes)

Screenshot 2024-04-15 at 2 48 26 PM

@gaecoli
Copy link
Member

gaecoli commented Apr 16, 2024

Thank you for your contribution. But this solution is not a universal one. I can provide you with an idea to re-develop a relative time component, or add a relative time component based on the existing one. Users can customize this relative time component. For example, Last xx days, months or years.

So I suggest not to merge this branch to master for the time being. 😁

@justinclift
Copy link
Member

I can provide you with an idea to re-develop a relative time component, or add a relative time component based on the existing one.

That sounds like the better approach. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants