Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

server : remove legacy system_prompt feature #9857

Merged
merged 3 commits into from
Oct 12, 2024
Merged

server : remove legacy system_prompt feature #9857

merged 3 commits into from
Oct 12, 2024

Conversation

ggerganov
Copy link
Owner

@ggerganov ggerganov commented Oct 12, 2024 •
edited
Loading

fix #9811

Not helpful anymore with the general availability of finetuned models that properly support system prompts via chat templates.

@ggerganov ggerganov mentioned this pull request Oct 12, 2024
Open
@ggerganov ggerganov mentioned this pull request Oct 12, 2024
Merged
@ngxson
Copy link
Collaborator

ngxson commented Oct 12, 2024

Please note that in a recent PR, I moved the ability to change system_promptat runtime from POST /completions to POST /props

It is handle by handle_props_change. So I think for now we can remove handle_props_change.

@ggerganov
Copy link
Owner Author

I think we can keep the /props endpoint as a placeholder in case we decide to add similar functionality in the future.

@ggerganov ggerganov merged commit 95c76e8 into master Oct 12, 2024
54 checks passed
@ggerganov ggerganov deleted the gg/server-remove-system-prompt branch October 12, 2024 11:51
drollings pushed a commit to drollings/llama.cpp that referenced this pull request Oct 18, 2024
@ggerganov @drollings
server : remove legacy system_prompt feature (ggerganov#9857)
b7aea35 
* server : remove legacy system_prompt feature

ggml-ci

* readme : update [no ci]

* server : fix non-transformer logic + remove response from /props
dsx1986 pushed a commit to dsx1986/llama.cpp that referenced this pull request Oct 29, 2024
@ggerganov @dsx1986
server : remove legacy system_prompt feature (ggerganov#9857)
3554fad 
* server : remove legacy system_prompt feature

ggml-ci

* readme : update [no ci]

* server : fix non-transformer logic + remove response from /props
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FirstTimeEZ FirstTimeEZ FirstTimeEZ approved these changes

Assignees
No one assigned
Labels
examples server
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

server : remove system prompt support
3 participants
@ggerganov @ngxson @FirstTimeEZ