Skip to content

Add more manual bindings for async functions #953

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 16, 2023
Merged

Add more manual bindings for async functions #953

merged 3 commits into from
Sep 16, 2023

Conversation

fsobolev
Copy link
Contributor

  • I agree that my contribution may be licensed either under MIT or any version of LGPL license.

Added:

  • Gdk.Clipboard.ReadTextAsync
  • Gtk.AlertDialog.ChooseAsync
  • Gtk.FileDialog.OpenMultipleAsync
  • Gtk.FileDialog.SelectMultipleFoldersAsync

Related: #900

badcel
badcel requested changes Sep 16, 2023
View reviewed changes
Copy link
Member

@badcel badcel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All in all this looks pretty good to me. Some minor things to fix, then it should be good to go.

@badcel
Copy link
Member

badcel commented Sep 16, 2023

Thank you for your contribution 👍

@badcel badcel merged commit f658f15 into gircore:main Sep 16, 2023
@fsobolev fsobolev deleted the new-async branch September 16, 2023 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@badcel badcel badcel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fsobolev @badcel