Rebase enumerations on integer datatypes #989
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Int is the base type for enumerations - UInt is the base type for bitfields This matches the return types of the GObject.Value.GetEnum / GetFlags methods. With GTK3 support this was problematic as there were some enumerations (int based) which defined values in the range of unsigned integers. This was the reason long was used as it could handle all values which could be created either with integer or unsigned integer Starting with GTK4 such enumerations are not longer used and the base type can be switched to int / uint. In case such enumerations appear again those enumerations would probably need to be dynamically declared as uint based instead of int based. During runtime this must then be evaluated and handled accordingly (e.g. via Unsafe.As<int, uint>()).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With GTK3 support this was problematic as there were some enumerations (int based) which defined values in the range of unsigned integers. This was the reason long was used as it could handle all values which could be created either with integer or unsigned integer
Starting with GTK4 such enumerations are not longer used and the base type can be switched to int / uint.
In case such enumerations appear again those enumerations would probably need to be dynamically declared as uint based instead of int based. During runtime this must then be evaluated and handled accordingly (e.g. via Unsafe.As<int, uint>()).