-
Notifications
You must be signed in to change notification settings - Fork 41
Generate methods with untyped records as container-transfer return values #1328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
ousnius
wants to merge
1
commit into
gircore:main
Choose a base branch
from
ousnius:return-untyped-record-container
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The generated xml looks like this: <function name="returns_transfer_container"
c:identifier="girtest_untyped_record_tester_returns_transfer_container"
introspectable="0">
<source-position filename="girtest-untyped-record-tester.h" line="40"/>
<return-value>
<type name="UntypedRecordContainerTester"
c:type="GirTestUntypedRecordContainerTester*"/>
</return-value>
</function>
If you want to see if scenarios similar to As
<return-value transfer-ownership="container">
<doc xml:space="preserve"
filename="gdk-pixbuf/gdk-pixbuf-io.c"
line="3432">A list of
support image formats.</doc>
<type name="GLib.SList" c:type="GSList*">
<type name="PixbufFormat"/>
</type>
</return-value>
|
…lues "transfer-container" is usually used with GLib.List and GLib.SList as return values. The ownership of the returned container is transferred, but the ownership of the elements in the container is not. Example: gdk_pixbuf_get_formats
4e36f15
to
3cbe3a2
Compare
These untyped records exist:
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
transfer-container
is usually used withGLib.List
andGLib.SList
as return values.The ownership of the returned container is transferred, but the ownership of the elements in the container is not.
API examples:
gdk_pixbuf_get_formats
gtk_textiter_get_tags
Added a test that returns a container with two static elements that are owned by native code.