Add fetch/prune options to safe keys for lfsconfig #4114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some users want to specify other defaults for fetch/prune options, e.g., enable lfs.fetchrecentalways. Add fetch and prune options to list of safe keys for .lfsconfig. Update the documentation to include the new list safe keys.
|
I realize this PR is pretty old, but I'd still be interested in having this merged 🙂 Anyone around to review? 🙂 |
|
I think my position as outlined in #4111 still stands. I'm not comfortable with adding more keys to the |
|
Thanks, @bk2204 🙂 After thinking about this some more, I think our team probably wouldn't use this feature, anyway, because we wouldn't want these settings to apply to both our dev machines and the build server. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some users want to specify other defaults for fetch/prune options, e.g.,
enable lfs.fetchrecentalways.
Add fetch and prune options to list of safe keys for .lfsconfig.
Update the documentation to include the new list safe keys.
This adds the following keys to the list of safe keys:
Fixes #4111