Welcome to GitGitGadget

Hi @Imvedansh, and welcome to GitGitGadget, the GitHub App to send patch series to the Git mailing list from GitHub Pull Requests.

Please make sure that either:

• Your Pull Request has a good description, if it consists of multiple commits, as it will be used as cover letter.
• Your Pull Request description is empty, if it consists of a single commit, as the commit message should be descriptive enough by itself.

You can CC potential reviewers by adding a footer to the PR description with the following syntax:

CC: Revi Ewer <revi.ewer@example.com>, Ill Takalook <ill.takalook@example.net>

NOTE: DO NOT copy/paste your CC list from a previous GGG PR's description,
because it will result in a malformed CC list on the mailing list. See
example.

Also, it is a good idea to review the commit messages one last time, as the Git project expects them in a quite specific form:

• the lines should not exceed 76 columns,
• the first line should be like a header and typically start with a prefix like "tests:" or "revisions:" to state which subsystem the change is about, and
• the commit messages' body should be describing the "why?" of the change.
• Finally, the commit messages should end in a Signed-off-by: line matching the commits' author.

It is in general a good idea to await the automated test ("Checks") in this Pull Request before contributing the patches, e.g. to avoid trivial issues such as unportable code.

Contributing the patches

Before you can contribute the patches, your GitHub username needs to be added to the list of permitted users. Any already-permitted user can do that, by adding a comment to your PR of the form /allow. A good way to find other contributors is to locate recent pull requests where someone has been /allowed:

• Search: is:pr is:open "/allow"

Both the person who commented /allow and the PR author are able to /allow you.

An alternative is the channel #git-devel on the Libera Chat IRC network:

<newcontributor> I've just created my first PR, could someone please /allow me? https://github.com/gitgitgadget/git/pull/12345
<veteran> newcontributor: it is done
<newcontributor> thanks!

Once on the list of permitted usernames, you can contribute the patches to the Git mailing list by adding a PR comment /submit.

If you want to see what email(s) would be sent for a /submit request, add a PR comment /preview to have the email(s) sent to you. You must have a public GitHub email address for this. Note that any reviewers CC'd via the list in the PR description will not actually be sent emails.

After you submit, GitGitGadget will respond with another comment that contains the link to the cover letter mail in the Git mailing list archive. Please make sure to monitor the discussion in that thread and to address comments and suggestions (while the comments and suggestions will be mirrored into the PR by GitGitGadget, you will still want to reply via mail).

If you do not want to subscribe to the Git mailing list just to be able to respond to a mail, you can download the mbox from the Git mailing list archive (click the (raw) link), then import it into your mail program. If you use GMail, you can do this via:

curl -g --user "<EMailAddress>:<Password>" \
    --url "imaps://imap.gmail.com/INBOX" -T /path/to/raw.txt

To iterate on your change, i.e. send a revised patch or patch series, you will first want to (force-)push to the same branch. You probably also want to modify your Pull Request description (or title). It is a good idea to summarize the revision by adding something like this to the cover letter (read: by editing the first comment on the PR, i.e. the PR description):

Changes since v1:
- Fixed a typo in the commit message (found by ...)
- Added a code comment to ... as suggested by ...
...

To send a new iteration, just add another PR comment with the contents: /submit.

Need help?

New contributors who want advice are encouraged to join git-mentoring@googlegroups.com, where volunteers who regularly contribute to Git are willing to answer newbie questions, give advice, or otherwise provide mentoring to interested contributors. You must join in order to post or view messages, but anyone can join.

You may also be able to find help in real time in the developer IRC channel, #git-devel on Libera Chat. Remember that IRC does not support offline messaging, so if you send someone a private message and log out, they cannot respond to you. The scrollback of #git-devel is archived, though.

There are issues in commit a01e9ec:
t1410: modernize test path checks
Commit not signed off

/submit

Error: User Imvedansh is not yet permitted to use GitGitGadget

/allow

User Imvedansh is now allowed to use GitGitGadget.

WARNING: Imvedansh has no public email address set on GitHub; GitGitGadget needs an email address to Cc: you on your contribution, so that you receive any feedback on the Git mailing list. Go to https://github.com/settings/profile to make your preferred email public to let GitGitGadget know which email address to use.

/submit

Submitted as pull.2066.git.git.1759741252581.gitgitgadget@gmail.com

To fetch this version into FETCH_HEAD:

git fetch https://github.com/gitgitgadget/git/ pr-git-2066/Imvedansh/modernize-t1410-reflog-v1

To fetch this version to local tag pr-git-2066/Imvedansh/modernize-t1410-reflog-v1:

git fetch --no-tags https://github.com/gitgitgadget/git/ tag pr-git-2066/Imvedansh/modernize-t1410-reflog-v1

On the Git mailing list, Christian Couder wrote (reply to this):

On Mon, Oct 6, 2025 at 11:01 AM Imvedansh via GitGitGadget
<gitgitgadget@gmail.com> wrote:
>
> From: Imvedansh <veds17007@gmail.com>
>
> Convert old-style "test -f" and "! test -f" checks to use the
> modern helper functions 'test_path_is_file' and
> 'test_path_is_missing' in t/t1410-reflog.sh.
>
> This improves readability and consistency in the test suite.

I think that it might also improve the error message when a test fails, right?

> Signed-off-by: Imvedansh <veds17007@gmail.com>

We prefer when the "Signed-off-by:" contains the full real name of the
person contributing.

"Documentation/SubmittingPatches" says:

[[real-name]]
Please use a known identity in the `Signed-off-by` trailer, since we cannot
accept anonymous contributions. It is common, but not required, to use some form
of your real name. We realize that some contributors are not comfortable doing
so or prefer to contribute under a pseudonym or preferred name and we can accept
your patch either way, as long as the name and email you use are distinctive,
identifying, and not misleading.

The goal of this policy is to allow us to have sufficient information to contact
you if questions arise about your contribution.


> ---
>     t1410: modernize test path checks
>
>     Hello,
>
>     I'm Vedansh and I'm interested in contributing to Git through Outreachy
>     2025.

Thanks for your interest in contributing to Git!

>     I have successfully built Git from source on Ubuntu (via WSL2) and run
>     the test suite. All tests pass.
>
>     For my microproject, I'd like to modernize the path checking in
>     t/t1410-reflog.sh by replacing 'test -f' with test_path_is_file in lines
>     133-136 (in the 'rewind' test).
>
>     I found 4 instances that are assertions (part of && chains):
>
>      * test -f C
>      * test -f A/B/E
>      * ! test -f F
>      * ! test -f A/G
>
>     I've verified these are test assertions, not flow control statements,
>     and the test currently passes on my system.
>
>     Is this appropriate for a microproject?

It seems to me that Usman already answered this.

>  t/t1410-reflog.sh | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/t/t1410-reflog.sh b/t/t1410-reflog.sh
> index e30f87a358..ce71f9a30a 100755
> --- a/t/t1410-reflog.sh
> +++ b/t/t1410-reflog.sh
> @@ -130,10 +130,10 @@ test_expect_success 'pass through -- to sub-command' '
>
>  test_expect_success rewind '
>         test_tick && git reset --hard HEAD~2 &&
> -       test -f C &&
> -       test -f A/B/E &&
> -       ! test -f F &&
> -       ! test -f A/G &&
> +       test_path_is_file C &&
> +       test_path_is_file A/B/E &&
> +       test_path_is_missing F &&
> +       test_path_is_missing A/G &&

This looks good to me.

User Christian Couder <christian.couder@gmail.com> has been added to the cc: list.