Fix placeholder text formatting issues #1247
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes several bugs related to placeholders on master slides that can be observed in this minimal demo repo
Valign and Margin in master slides
When creating a placeholder on a master slide, the valign and margin options are disregarded on the layout slide (in ppt, go to View > Slide Master and examine the items added to the layout slide, even if you specify valign and/or margin, the items on the layout slide will still have the default values.
This issue is somewhat related to #640. The fix for that issue fixed the generated slides that use the master and placeholders from within the library, but unfortunately, it didn't fix the issue on the master slides themselves.
This causes issues when you generate a pptx and then you want to add more slides to that file manually in PowerPoint using the generated master slides.
Bullets in master slides
This one is very specific and probably doesn't come up much, but it came up for me, and since I was already in the library fixing the above issue, I decided to also developed a fix for this one.
When you supply
type: "bullet"
and a customcharacterCode
to bulleted text in a placeholder, the placeholder still uses the default bullet code2022
. The easy workaround is to just not supply a type and it will default to bullet, but it is very confusing when you run into it.e.g.