C#: Add MaD support for Attribute.Getter and Attribute.Setter.
#17459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbd8340
to
3130df7
Compare
3130df7
to
3c911b2
Compare
…for use in external models.
3c911b2
to
bdc0084
Compare
|
DCA looks good! |
tamasvajk
reviewed
Sep 17, 2024
| @@ -289,7 +288,7 @@ module ModelValidation { | |||
| not signature.regexpMatch("|\\([a-zA-Z0-9_<>\\.\\+\\*,\\[\\]]*\\)") and | |||
| result = "Dubious signature \"" + signature + "\" in " + pred + " model." | |||
| or | |||
| not ext.regexpMatch("|Attribute") and | |||
| not ext = ["", "Attribute", "Attribute.Getter", "Attribute.Setter"] and | |||
There was a problem hiding this comment.
I think we should mention these new extensions in the comment at the top of the file.
Comment on lines
+416
to
+417
| not result instanceof Property and | ||
| not result instanceof Indexer |
There was a problem hiding this comment.
Would we be backwards compatible if we removed these two lines?
There was a problem hiding this comment.
Yes, but I think we should take a conscious decision and break the backwards compatibility - as it was quite surprising that tagging a property meant that it worked for setters.
Also, the public documentation doesn't contain the explanation on, how to use the ext field, so it is most likely not heavily used (yet).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR we added support for
Attribute.GetterandAttribute.Setteras a part of the models as data description in theextfield of a model.Assume we have the following declarations.
If we add the following source model
- ["N", "SourceAttribute", false, "", "", "Attribute.Getter", "ReturnValue", "local", "manual"]Then
TaggedSrcPropertyGetteris considered alocalsource of taint.